On Mon, 9 Nov 2009, Gustavo Sverzut Barbieri wrote:

On Mon, Nov 9, 2009 at 8:22 AM, Enlightenment SVN
<[email protected]> wrote:
Log:
 note about distcheck b0rken


Author:       raster
Date:         2009-11-09 02:22:08 -0800 (Mon, 09 Nov 2009)
New Revision: 43570

Modified:
 trunk/ethumb/Makefile.am

Modified: trunk/ethumb/Makefile.am
===================================================================
--- trunk/ethumb/Makefile.am    2009-11-09 10:21:38 UTC (rev 43569)
+++ trunk/ethumb/Makefile.am    2009-11-09 10:22:08 UTC (rev 43570)
@@ -24,6 +24,8 @@
 if USE_MODULE_ETHUMBD

 pkgconfig_DATA += ethumb_client.pc
+## FIXME: this breaks "make distcheck" as this installs somethnig outside of
+## the prefix. try make distcheck (as a user)
 servicedir = $(dbusservicedir)
 service_DATA = org.enlightenment.Ethumb.service

ideas on how to solve this without screwing users?

If user == root, then good as it will generate distcheck and install
correctly to dbus services dir (/usr/share/dbus-1)

however, if user != root:
   1. we fix distcheck and users will complain ethumbd was not
auto-started as it's not in ~/.config
   2. install it correctly for users, but distcheck will fail

Maybe is there a way to know the "mode" being run? Or to give
distcheck some extra parameters, like
--with-dbus-services=$DESTDIR/xxx

ideas?

we can pass options to configure when running distcheck :

DISTCHECK_CONFIGURE_FLAGS

see http://www.gnu.org/software/automake/manual/automake.html#Checking-the-Distribution

Vincent
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to