For such cases is better to have a _eet_OP_unlocked(), such as _eet_close_unlocked() and so... it makes code much easier (since eet_close() would just lock and call) and it would be safer since we don't release lock before closing.
Could someone change this? I can't atm. On Thu, Dec 3, 2009 at 11:15 PM, Enlightenment SVN <[email protected]> wrote: > Log: > deadlock fuckers! fix! :) > > > Author: raster > Date: 2009-12-03 17:15:19 -0800 (Thu, 03 Dec 2009) > New Revision: 44179 > > Modified: > trunk/eet/src/lib/eet_lib.c > > Modified: trunk/eet/src/lib/eet_lib.c > =================================================================== > --- trunk/eet/src/lib/eet_lib.c 2009-12-03 22:26:37 UTC (rev 44178) > +++ trunk/eet/src/lib/eet_lib.c 2009-12-04 01:15:19 UTC (rev 44179) > @@ -1352,7 +1352,9 @@ > eet_flush2(ef); > ef->references++; > ef->delete_me_now = 1; > + UNLOCK_CACHE; > eet_close(ef); > + LOCK_CACHE; > } > ef = eet_cache_find((char *)file, eet_readers, eet_readers_num); > } > @@ -1364,12 +1366,14 @@ > { > ef->delete_me_now = 1; > ef->references++; > + UNLOCK_CACHE; > eet_close(ef); > + LOCK_CACHE; > } > ef = eet_cache_find((char *)file, eet_writers, eet_writers_num); > } > UNLOCK_CACHE; > - > + > /* try open the file based on mode */ > if ((mode == EET_FILE_MODE_READ) || (mode == EET_FILE_MODE_READ_WRITE)) > { > > > ------------------------------------------------------------------------------ > Join us December 9, 2009 for the Red Hat Virtual Experience, > a free event focused on virtualization and cloud computing. > Attend in-depth sessions from your desk. Your couch. Anywhere. > http://p.sf.net/sfu/redhat-sfdev2dev > _______________________________________________ > enlightenment-svn mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
