On Mon, Jan 4, 2010 at 7:55 PM, Vincent Torri <[email protected]> wrote:
>
>
> On Mon, 4 Jan 2010, Enlightenment SVN wrote:
>
>> Log:
>>       * emotion: Use the right macro.
>>
>> Author:       cedric
>> Date:         2010-01-04 13:28:24 -0800 (Mon, 04 Jan 2010)
>> New Revision: 44895
>>
>> Modified:
>>  trunk/emotion/src/bin/emotion_test_main.c 
>> trunk/emotion/src/modules/gstreamer/emotion_gstreamer.c 
>> trunk/emotion/src/modules/vlc/emotion_vlc.c 
>> trunk/emotion/src/modules/xine/emotion_xine.c
>>
>> Modified: trunk/emotion/src/bin/emotion_test_main.c
>> ===================================================================
>> --- trunk/emotion/src/bin/emotion_test_main.c 2010-01-04 21:03:06 UTC (rev 
>> 44894)
>> +++ trunk/emotion/src/bin/emotion_test_main.c 2010-01-04 21:28:24 UTC (rev 
>> 44895)
>> @@ -112,22 +112,14 @@
>>      }
>>    if (mode == 4)
>>      ecore_evas = ecore_evas_new(NULL, 0, 0, startw, starth, NULL);
>> -# if HAVE_EVAS_SOFWARE_X11
>>    if (mode == 0)
>>      ecore_evas = ecore_evas_software_x11_new(NULL, 0,  0, 0, startw, 
>> starth);
>> -# endif
>> -# if HAVE_EVAS_OPENGL_X11
>>    if (mode == 1)
>>      ecore_evas = ecore_evas_gl_x11_new(NULL, 0, 0, 0, startw, starth);
>> -# endif
>> -# if HAVE_EVAS_FB
>>    if (mode == 2)
>>      ecore_evas = ecore_evas_fb_new(NULL, 0, startw, starth);
>> -# endif
>> -# if HAVE_EVAS_XRENDER_X11
>>    if (mode == 3)
>>      ecore_evas = ecore_evas_xrender_x11_new(NULL, 0, 0, 0, startw, starth);
>> -# endif
>
> why do you remove them ? I have added checks in configure.ac for those
> macro

IMHO this is just pointless... use ecore_evas_new() and it will do
that internally. If user want to override, you can always give the
first parameter as !NULL or user can still specify using envvars.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [email protected]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to