On 01/08/2010 07:10 PM, Iván Briano (Sachiel) wrote: > On Fri, Jan 8, 2010 at 9:04 PM, Christopher Michael > <[email protected]> wrote: >> On 01/08/2010 05:03 PM, Gustavo Sverzut Barbieri wrote: >>> Hi all, >>> >>> Today I used enlightenment without -fvisibility=hidden and noticed a >>> complain of mixer/connman users: they clash. Investigating the cause, >>> I found that _Name were not defined static in both, so they clashed. I >>> fixed my modules, but then I ran a quick script over modules and got >>> the following list (please investigate further). I'm about to travel >>> so I can't fix them now, please help: >>> >>> note: I hand edited and cut some obvious cases, but the command was: >>> >>> for m in *; do echo "$m:"; readelf -s >>> /usr/lib/enlightenment/modules/$m/linux-gnu-i686-ver-pre-svn-05/module.so >>> | grep 'GLOBAL DEFAULT' | grep -v 'UND ' | grep -v >>> "\(_fini\|_init\|__bss_start\|_end\|_edata\|e_modapi\|evry\|e_kbd_\|il_\|e_int_\|e_fwin\|_\?e_$m\|_\?$m\)" >>> | sed "s/.* \([a-zA-Z0-9_]\+\)/ \1/g"; done >>> >> >> <snip> >> >>> illume2 >>> policy_name >>> o_top >>> _sw_change_timer >>> _ps_change_timer >>> stype >>> _windows_change_timer >>> o_left >>> _anim_change_timer >>> _policy_change_timer >>> illume-home >>> delay_slider >>> delay_label >>> illume-keyboard >>> external >>> illume-softkey >>> e_mod_sk_win_shutdown >>> e_mod_sk_win_new >> >> I think there may be something wrong with that script you ran. >> >> For instance, it detected _sw_change_timer as a collision ? Yet nowhere >> else is _sw_change_timer being used....so how is that a collision ? I >> searched the entire svn repo and nothing is using that other than >> illume2....and at that, it's a local variable inside the Select Window >> code. For that matter, how could e_mod_sk_win_shutdown be a collision ? >> it's a unique function name what is not being used anywhere else ?? >> > > He's not saying that they are clashing with anything now, they just are > unnecessary public symbols that may collide. > >> dh >>
Ahh ok. I misunderstood then. Thanks :) I have a lot of changes to the illume2 modules (about every one of them) that I have not committed yet. Before I do, I'll rename a few of those problem areas and get that straightened up. dh ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
