On Tue, 2 Feb 2010 07:50:48 +0100 (CET) Vincent Torri <[email protected]>
said:
>
>
> >> +AM_ICONV
> >
> > that m4 macro is provided by gettext in ecore. I don't see it. I don't
> > know if it is a problem, but iconv.m4 file is licenced as GPL (like
> > gettext). If it's a problem, i'll write one.
> >>
> >> libeina_la_LIBADD = @EINA_LIBS@ @dlopen_libs@
> >> -libeina_la_LDFLAGS = -no-undefined @lt_enable_auto_import@ -version-info
> >> @version_info@ @release_info@ @EFL_PTHREAD_LIBS@ -libeina_la_CFLAGS =
> >> @EINA_CFLAGS@ @EFL_PTHREAD_CFLAGS@ +libeina_la_LDFLAGS = -no-undefined
> >> @lt_enable_auto_import@ -version-info @version_info@ @release_info@
> >> @EFL_PTHREAD_LIBS@ @iconv_libs@
> >
> > @iconv_libs@ should go in _LIBADD
> >
> >> +libeina_la_CFLAGS = @EINA_CFLAGS@ @EFL_PTHREAD_CFLAGS@ @iconv_cflags@
> >
> > @iconv_cflags@ should go in _CPPFLAGS
>
> the above is fixed
>
> >
> >> +EAPI char *
> >> +eina_str_convert(const char *enc_from, const char *enc_to, const char
> >> *text) +{
> >> +#ifdef HAVE_ICONV
> >
> > [snip]
> >
> >> +#else
> >> + return NULL;
> >
> > is NULL really what we should return ? Why not test itself ?
>
> this is not fixed. should i return strdup(txt) ?
null is fine. failed conversion.
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [email protected]
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
