Hi all, I'm not to sure about this. I was actually looking at where to put this call, and seeing that the screen locking code itself is deeply rooted in the core of e and not in a module I put it under core.
I think that centrally collecting dbus APIs in a separate module does not make much sense because then you'd have to check whether the related module is loaded (e.g. I don't even have the language module loaded...) If a module provides functionality, it should register the dbus API itself so you don't advertise functions that don't actually work. Putting the desklock call in the "core" dbus hierarchy however is debatable, it was quick and dirty. It probably would be better to add a Desklock hierarchy and add the other few parameters (autolock time if wanted, or similar) there, too. Regards, Christian Carsten Haitzler (The Rasterman) wrote: > On Wed, 27 Jan 2010 21:45:47 +0100 "Christian P. Schmidt" <[email protected]> > said: > > hmm thumbs and down on this one. > > up because you ddid it at all and created a dbus api. down because i think it > doesnt belong in the core wm api. the core dbus api is very simple and core - > modules are meant for extending it. look at msgbug_lang. > > maybe we should rename msgbus_lang to msgbus_extras that cann collect little > extra dbus api's like this (also the lang ones too). how does that sound? put > it there and rename the module? > >> Hi all, >> >> Since I'm used to my laptop locking when I suspend it I wasn't >> particularly delighted to see the new enlightenment_remote. Until e >> catches ACPI events and manages to lock automatically I decided to take >> a shortcut and expose the lock function via dbus. >> I don't know if directly calling it is the right way, or if I should >> instead queue an event... but I couldn't find any code that would show >> such an event. >> >> Regards, >> Christian >> > > ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
