On Sun, 28 Feb 2010, Enlightenment SVN wrote:
> Log:
> remove warnings from edje binaries.
>
> Author: barbieri
> Date: 2010-02-28 08:14:50 -0800 (Sun, 28 Feb 2010)
> New Revision: 46647
>
> Modified:
> trunk/edje/src/bin/edje_cc_parse.c trunk/edje/src/bin/edje_decc.c
>
> Modified: trunk/edje/src/bin/edje_cc_parse.c
> ===================================================================
> --- trunk/edje/src/bin/edje_cc_parse.c 2010-02-28 15:57:17 UTC (rev
> 46646)
> +++ trunk/edje/src/bin/edje_cc_parse.c 2010-02-28 16:14:50 UTC (rev
> 46647)
> @@ -806,6 +806,7 @@
> {
> char *str;
> char *end;
> + long val;
>
> str = eina_list_nth(params, n);
> if (!str)
> @@ -816,7 +817,7 @@
> }
> if (str[0] == 0) return 0;
> end = str;
> - strtol(str, &end, 0);
> + val = strtol(str, &end, 0);
what's the interest of fixing such warning if you don't check the returned
value ? same for fwrite below
Vincent
> if ((end != str) && (end[0] == 0)) return 1;
> return 0;
> }
>
> Modified: trunk/edje/src/bin/edje_decc.c
> ===================================================================
> --- trunk/edje/src/bin/edje_decc.c 2010-02-28 15:57:17 UTC (rev 46646)
> +++ trunk/edje/src/bin/edje_decc.c 2010-02-28 16:14:50 UTC (rev 46647)
> @@ -14,6 +14,7 @@
> #include <locale.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> +#include <errno.h>
>
>
> #include <Ecore_File.h>
> @@ -305,7 +306,8 @@
> exit (-1);
> }
> f = fopen(out, "wb");
> - fwrite(font, fontsize, 1, f);
> + if (fwrite(font, fontsize, 1, f) != 1)
> + ERR("Could not write font: %s", strerror(errno));
> fclose(f);
> free(font);
> }
>
>
> ------------------------------------------------------------------------------
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> enlightenment-svn mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
