Ping? Would it be more convenient to send the patch and test programs directly to the list? (I know people usually do this, but since it's a number of files, I figured it might be cumbersome.)
pete On Thu, Feb 25, 2010 at 09:51:01PM -0500, Peter Johnson wrote: > Here's a tarball containing a prospective patch and a few commented test > programs: > > http://tam.hiddenrock.com/eina-log-default.tar.gz > > I haven't yet updated the documentation because I'm not entirely convinced > it's correct, but I'm not sure why, so I'd like a few second pairs of eyes on > it. Thanks. > > pete > > On Thu, Feb 25, 2010 at 05:18:10PM -0300, Gustavo Sverzut Barbieri wrote: > > On Thu, Feb 25, 2010 at 5:00 PM, Peter Johnson <t...@hiddenrock.com> wrote: > > > Cool, thanks. > > > > > > My reading of those pages indicates that, were I to follow the > > > recommendations > > > contained therein, I would always use the EINA_LOG_DOM_*() macros and > > > never > > > the EINA_LOG_*() macros, because they use EINA_LOG_DOMAIN_GLOBAL, and as a > > > good developer I should have my own domain(s) for my project. > > > > > > I think it would be helpful to allow developers to specify a logging > > > domain > > > for an entire source file, which the EINA_LOG_*() macros would use. This > > > would cut down on typing and errors in consistency, and increase the SNR > > > of my > > > code. > > > > > > My suggestion: the EINA_LOG_*() macros always log to > > > EINA_LOG_DOMAIN_DEFAULT, > > > which would initially be set to EINA_LOG_DOMAIN_GLOBAL, and may be > > > overridden > > > by a developer in a particular file. The complication is that it would > > > have > > > to be reset for the next file. On the other hand, it could encourage > > > better > > > developer habits regarding header files and whatnot. > > > > Hum... this do make sense. I even like the short 3 letter macros, but > > doing this could be very helpful and backwards compatible! > > > > Could you send a patch doing that, with documentation updated? > > > > BR, > > > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: barbi...@gmail.com > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
