On Fri, Mar 26, 2010 at 10:42 AM, Iván Briano (Sachiel)
<[email protected]> wrote:
> On Fri, Mar 26, 2010 at 10:19 AM, Brian Wang <[email protected]>
> wrote:
>> Any comments? Or I'm the only one experiencing the problem?
>>
>> Thanks in advance. :-)
>>
>
> First part looks good, second one I have no idea.
> But I'm too lazy to split it and apply it.
OK.
The patch to the first part is attached. :-)
>
>>
>> brian
>>
>> On Wed, Mar 24, 2010 at 3:44 PM, Brian Wang <[email protected]>
>> wrote:
>>> Hello all,
>>>
>>> The patch addresses two problems:
>>> 1. Ecore Timer complaints (ECORE MAGIC failures). I ran a simple
>>> test program with gdb and found it's related to it->long_timer. The
>>> complaints happen from time to time but it is not very easy to
>>> reproduce. The patch addresses the only suspicious bit I found by
>>> code inspection.
>>> 2. When a genlist is dragged around, items that are supposed to be
>>> off the screen often appear as though they are left behind. The patch
>>> removes the check for it->dragging before _item_unrealize(). I'm not
>>> sure what the check is for. I tested the patch and did not notice any
>>> side effects.
>>>
>>> Please have a look at the attached patch and correct it if you see fit.
>>>
>>> Cheers,
>>>
>>>
>>> brian
>>>
>>> --
>>> brian
>>> ------------------
>>>
>>> Cool-Karaoke - The smallest recording studio, in your palm, open-sourced
>>> http://cool-idea.com.tw/
>>>
>>> iMaGiNaTiOn iS mOrE iMpOrTaNt tHaN kNoWlEdGe
>>>
>>
>>
>>
>> --
>> brian
>> ------------------
>>
>> Cool-Karaoke - The smallest recording studio, in your palm, open-sourced
>> http://cool-idea.com.tw/
>>
>> iMaGiNaTiOn iS mOrE iMpOrTaNt tHaN kNoWlEdGe
>>
>> ------------------------------------------------------------------------------
>> Download Intel® Parallel Studio Eval
>> Try the new software tools for yourself. Speed compiling, find bugs
>> proactively, and fine-tune applications for parallel performance.
>> See why Intel Parallel Studio got high marks during beta.
>> http://p.sf.net/sfu/intel-sw-dev
>> _______________________________________________
>> enlightenment-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>
--
brian
------------------
Cool-Karaoke - The smallest recording studio, in your palm, open-sourced
http://cool-idea.com.tw/
iMaGiNaTiOn iS mOrE iMpOrTaNt tHaN kNoWlEdGe
Index: elm_genlist.c
===================================================================
--- elm_genlist.c (revision 47380)
+++ elm_genlist.c (working copy)
@@ -938,7 +938,11 @@
Evas_Object *icon;
if (!it->realized) return;
- if (it->long_timer) ecore_timer_del(it->long_timer);
+ if (it->long_timer)
+ {
+ ecore_timer_del(it->long_timer);
+ it->long_timer = NULL;
+ }
evas_object_del(it->base);
it->base = NULL;
evas_object_del(it->spacer);
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
