On Tue, Mar 30, 2010 at 7:15 AM, Enlightenment SVN <[email protected]> wrote: > Log: > comment++ > > > Author: raster > Date: 2010-03-29 22:15:33 -0700 (Mon, 29 Mar 2010) > New Revision: 47577 > > Modified: > trunk/efreet/src/lib/efreet_desktop.c > > Modified: trunk/efreet/src/lib/efreet_desktop.c > =================================================================== > --- trunk/efreet/src/lib/efreet_desktop.c 2010-03-30 05:03:57 UTC (rev > 47576) > +++ trunk/efreet/src/lib/efreet_desktop.c 2010-03-30 05:15:33 UTC (rev > 47577) > @@ -745,6 +745,10 @@ > eina_list_free(desktop->categories); > eina_list_free(desktop->mime_types); > IF_FREE_HASH(desktop->x); > + // FIXME: loaded from eet. eet data descriptior is the default eina > + // setup that means all strings are "eina_stringshare_add()"ed. this > + // means we need to eina_stringshare_del() them here - until this is > + // no longer the case (they are directly mmaped) > } > else > { >
I don't understand this comment. Efreet code seems to correctly use eet_eina_file_data_descriptor_class_set that correctly setup callback to directly use mmaped string. So why are you referring to stringshare ? -- Cedric BAIL ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
