On Mon, 17 May 2010, Mike McCormack wrote:
> Vincent Torri wrote: > >> * add a file, named ecore_epoll.c instead of having lots of #ifdef > > I added 2 ifdefs vs. 11 for _WIN32. I could get it down to one if you would > insist. it's cleaner imho. The _WIN32 are necessary, unfortunately. > Adding a separate file would mean no inlining. i don't think so : put all the static inline in a .h and include tat file in ecore_main.c Also, are those inline really important ? >> * don't add an _init() in ecore_main.c, but in the above file > > epoll_fd should be created just once. In which function ecore_epoll_init() > and file should I add it? ecore_epoll.c Also, rename the variable : _ecore_epoll_init Vincent ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
