On Mon, 14 Jun 2010, Cedric BAIL wrote:

On Mon, Jun 14, 2010 at 2:35 PM, Vincent Torri <[email protected]> wrote:
On Mon, 14 Jun 2010, Enlightenment SVN wrote:
Log:
         * eyelight: move edje shutdown to prevent destruction of living object,
         fix lauching all in one presentation file.


Author:       cedric
Date:         2010-06-14 05:30:39 -0700 (Mon, 14 Jun 2010)
New Revision: 49664
Modified: trunk/PROTO/eyelight/src/lib/eyelight_viewer.c
===================================================================
--- trunk/PROTO/eyelight/src/lib/eyelight_viewer.c    2010-06-14 08:16:47 UTC 
(rev 49663)
+++ trunk/PROTO/eyelight/src/lib/eyelight_viewer.c    2010-06-14 12:30:39 UTC 
(rev 49664)
@@ -42,12 +42,12 @@
      goto shutdown_eina;
    }

+    if (!edje_init())
+     goto shutdown_ecore_evas;
+
    if (!ecore_evas_init())
      goto shutdown_eina;

-    if (!edje_init())
-     goto shutdown_ecore_evas;
-
    return _eyelight_init_count;

 shutdown_ecore_evas:
@@ -63,8 +63,8 @@
    if (--_eyelight_init_count != 0)
        return _eyelight_init_count;

+    ecore_evas_shutdown();
    edje_shutdown();
-    ecore_evas_shutdown();
    eina_log_domain_unregister(_eyelight_log_dom_global);
    _eyelight_log_dom_global = -1;
    eina_shutdown();

isn't this a bit fat hack for masking a problem that should be correctly
fixed elsewhere ?

I don't think so. Living Evas canvas could still hold reference to
Edje Object, so we need to wait for the canvas to be destroyed before
we could safely shutdown Edje. It makes sense to me, don't know if
it's really logic :-)

so what about destroying the Ecore_Evas ?

Vincent
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to