Hello all,

valgrind complains about an invalid write in elm_layout_content_set().
This happens in elm_layout_content_set(),
elm_layout_content_set : evas_object_del(si->obj)
_sub_del : free(si)
elm_layout_content_set : si->obj = NULL;  // invalid access to the freed si

The attached patch should fix this.

Please change it as you see fit.

Thanks.


brian

-- 
brian
------------------

Cool-Karaoke - The smallest recording studio, in your palm, open-sourced
http://cool-idea.com.tw/

iMaGiNaTiOn iS mOrE iMpOrTaNt tHaN kNoWlEdGe
Index: elementary/src/lib/elm_layout.c
===================================================================
--- elementary/src/lib/elm_layout.c     (revision 49917)
+++ elementary/src/lib/elm_layout.c     (working copy)
@@ -233,9 +233,12 @@
      {
        if (!strcmp(swallow, si->swallow))
          {
+            Evas_Object *tmp;
+
             if (content == si->obj) return;
-            evas_object_del(si->obj);
+            tmp = si->obj;
             si->obj = NULL;
+            evas_object_del(tmp);
             break;
          }
      }
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to