On Thu, Jul 1, 2010 at 10:38 PM, Enlightenment SVN <[email protected]> wrote: > Log: > Fix callback signatures > The change from returning int to Eina_Bool left several call sites with > warnings because they were not updated. Here they are fixed by using > Coccinelle, a tool that allows us to automate tasks like that. This
I'd like to apply more patches like this one using Coccinelle. It's a great tool to rapidly make changes on API. A problem though is with some macros that a project uses that needs some care. So, I'm now updating only ecore. It's compiled and running here. Let me know if there's any problem. I will apply the same semantic patch for the other libraries, E and E-MODULES-EXTRA. The later has the biggest patch. Recently Barbieri made a fix for a bug similar to: char *b; int *a = calloc(sizeof(*b)); With Coccinelle it's also possible to find bugs like that, and all at once. In my opinion it'd be good if we could run checks like this regularly. So, besides having a "make check", I'm thinking in add a "make coccicheck". Let me know what do you think. For example, on this commit the following messages came out on my stdout: WARNING: wrong callback _ecore_fb_event_filter_filter! ( src/lib/ecore_fb/ecore_fb_vt.c:265 ) WARNING: wrong callback _ecore_fb_li_device_fd_callback! ( src/lib/ecore_fb/ecore_fb_li.c:353 ) WARNING: wrong callback _ecore_fb_kbd_fd_handler! ( src/lib/ecore_fb/ecore_fb_kbd.c:157 ) WARNING: wrong callback _ecore_xcb_event_filter_filter! ( src/lib/ecore_x/xcb/ecore_xcb.c:1030 ) WARNING: wrong callback _ecore_directfb_input_event_fd_handler! ( src/lib/ecore_directfb/ecore_directfb.c:397 ) WARNING: wrong callback _ecore_directfb_window_event_fd_handler! ( src/lib/ecore_directfb/ecore_directfb.c:423 ) WARNING: wrong callback _ecore_config_ipc_client_add! ( src/lib/ecore_config/ecore_config_ipc_ecore.c:239 ) WARNING: wrong callback _ecore_config_ipc_client_del! ( src/lib/ecore_config/ecore_config_ipc_ecore.c:255 ) WARNING: wrong callback _ecore_config_ipc_client_sent! ( src/lib/ecore_config/ecore_config_ipc_ecore.c:271 ) WARNING: wrong callback _ecore_evas_event_mouse_wheel! ( src/lib/ecore_evas/ecore_evas_fb.c:181 ) WARNING: wrong callback _ecore_evas_event_key_down! ( src/lib/ecore_evas/ecore_evas_fb.c:111 ) WARNING: wrong callback _ecore_evas_event_key_up! ( src/lib/ecore_evas/ecore_evas_fb.c:124 ) WARNING: wrong callback _ecore_evas_event_mouse_button_down! ( src/lib/ecore_evas/ecore_evas_fb.c:137 ) WARNING: wrong callback _ecore_evas_event_mouse_button_up! ( src/lib/ecore_evas/ecore_evas_fb.c:154 ) WARNING: wrong callback _ecore_evas_event_mouse_move! ( src/lib/ecore_evas/ecore_evas_fb.c:168 ) WARNING: wrong callback _ecore_evas_directfb_event_key_up! ( src/lib/ecore_evas/ecore_evas_directfb.c:97 ) WARNING: wrong callback _ecore_evas_directfb_event_button_down! ( src/lib/ecore_evas/ecore_evas_directfb.c:126 ) WARNING: wrong callback _ecore_evas_directfb_event_button_up! ( src/lib/ecore_evas/ecore_evas_directfb.c:141 ) WARNING: wrong callback _ecore_evas_directfb_event_motion! ( src/lib/ecore_evas/ecore_evas_directfb.c:112 ) WARNING: wrong callback _ecore_evas_directfb_event_enter! ( src/lib/ecore_evas/ecore_evas_directfb.c:157 ) WARNING: wrong callback _ecore_evas_directfb_event_leave! ( src/lib/ecore_evas/ecore_evas_directfb.c:172 ) WARNING: wrong callback _ecore_evas_directfb_event_wheel! ( src/lib/ecore_evas/ecore_evas_directfb.c:189 ) WARNING: wrong callback _ecore_evas_directfb_event_got_focus! ( src/lib/ecore_evas/ecore_evas_directfb.c:203 ) WARNING: wrong callback _ecore_evas_directfb_event_lost_focus! ( src/lib/ecore_evas/ecore_evas_directfb.c:217 ) WARNING: wrong callback _ecore_evas_cocoa_event_lost_focus! ( src/lib/ecore_evas/ecore_evas_cocoa.c:103 ) WARNING: wrong callback _ecore_evas_cocoa_event_video_resize! ( src/lib/ecore_evas/ecore_evas_cocoa.c:116 ) WARNING: wrong callback _ecore_evas_cocoa_event_video_expose! ( src/lib/ecore_evas/ecore_evas_cocoa.c:131 ) WARNING: wrong callback _quit_cb! ( src/tests/ecore_test_ecore.c:16 ) WARNING: wrong callback _dummy_cb! ( src/tests/ecore_test_ecore.c:25 ) WARNING: wrong callback _timer2! ( src/tests/ecore_test_ecore.c:164 ) WARNING: wrong callback _timer3! ( src/tests/ecore_test_ecore.c:158 ) WARNING: wrong callback _timer1! ( src/tests/ecore_test_ecore.c:171 ) WARNING: wrong callback _fd_handler_cb! ( src/tests/ecore_test_ecore.c:202 ) WARNING: wrong callback _event_handler_cb! ( src/tests/ecore_test_ecore.c:243 ) WARNING: wrong callback _timer_quit_recursive! ( src/tests/ecore_test_ecore.c:280 ) WARNING: wrong callback _event_recursive_cb! ( src/tests/ecore_test_ecore.c:289 ) Lucas De Marchi ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
