On Monday, 05 July 2010, at 10:08:37 (+0800), Brett Nash wrote: > Oh... personal attacks. I knew this thread was missing something.
"Being a douche" is not a personal attack. It's an opinion. "You are a douche" is a personal attack. Besides, the thread's not missing personal attacks. "If you check the return value of alloca(), you don't know what it does" is an insult (not to mention a generalization, and logically fallacious). > Short answer: If checking the return of alloca is so important to you > then either commit a fix or send a patch. > > I still am of the opionion that checking the return of alloca means you > don't know what it does. You can ignore what Jose says, but that doesn't make him any less right. And raster is a clear counter-example which disproves your rule. > In the specific case you mentioned the code also called free on the > return of alloca. So my little rule did indeed catch a real bug. That's great. But it also helps prove Jose's point that this was probably a case where malloc() was replaced with alloca() and the free was mistakenly left in. That doesn't mean that raster doesn't know what alloca() does. I also assert that one does not know what alloca() does on every single platform that exists or will exist, and checking the return value adds maybe two instructions, assuming they don't get optimized out. I can list other examples of short-sighted hard-coding of optimizations that later resulted in suckage, but I'm pretty sure you've stopped listening. Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <m...@kainx.org> Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org) ----------------------------------------------------------------------- "A lot of times, men do things they don't want to do so the woman they're going out with will do things *they* don't want to do." -- Tim Allen ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
