On Mon, Jul 12, 2010 at 3:06 PM, Vincent Torri <[email protected]> wrote: > > > On Mon, 12 Jul 2010, Enlightenment SVN wrote: > >> Log: >> Fix accounting safeness logic introduced at rev. 50158. >> >> >> Author: antognolli >> Date: 2010-07-12 10:59:48 -0700 (Mon, 12 Jul 2010) >> New Revision: 50202 >> >> Modified: >> trunk/ecore/src/lib/ecore/ecore_timer.c >> >> Modified: trunk/ecore/src/lib/ecore/ecore_timer.c >> =================================================================== >> --- trunk/ecore/src/lib/ecore/ecore_timer.c 2010-07-12 17:20:14 UTC (rev >> 50201) >> +++ trunk/ecore/src/lib/ecore/ecore_timer.c 2010-07-12 17:59:48 UTC (rev >> 50202) >> @@ -553,7 +553,10 @@ >> } >> >> timer->references++; >> - if (!timer->func(timer->data)) ecore_timer_del(timer); >> + if (!timer->func(timer->data)) >> + { >> + if (!timer->delete_me) ecore_timer_del(timer); >> + } > > can be replaced by > > if (!timer->func(timer->data) && !timer->delete_me) > ecore_timer_del(timer); > > I don't know if it could be more optimized that way
we know about it, discussed it internally, but the committed version is more readable. about optimized or not, it is the same for compilers. BR, -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
