On Thu, Aug 19, 2010 at 10:09 AM, Tom Hacohen <tom.haco...@partner.samsung.com> wrote: > On Thu, 2010-08-19 at 06:59 +1000, Carsten Haitzler wrote: >> as for forcing -W's into builds. no. this is compiler dependent AND it's the >> task of CFLAGS. you can make this happen for you NOW. >> >> export CFLAGS="-W -Wall -Wextra -Werror" > Nope doesn't work, as can be seen by the Makefile generated by > autotools: > CFLAGS = -g -O0 -D_GNU_SOURCE > (-g and -O0 are mine) i.e it sets the CFLAGS and does not use the old > value. (also confirmed by actually trying to build like that). > > The only way I know of (and I'm really no expert) is passing the flags > you want to autotools which is not much of a hassle as well so the > CFLAGS not working is not the issue here anyway. > >> etc. done. nothing to be changed anywhere in any svn in any source tree. by >> putting it on there you force error output for those that simply dont want it >> OR don't care and wont read it anyway, or it simply confuses them. > If people writing code to efl (as Vincent Torri said we can do it only > for devs) get confused/don't care about warnings we have a major problem > here. As I said, Warnings are great for finding bugs and once you also > use -Wno-unused-parameter you also get rid of the more annoying ones :P > >> we have >> enough gentoo users who are unable to read as it is. (sorry - have to say >> that, >> but it's true - there are enough who simply paste compiler output just so we >> can become reading services. SIMPLE errors like "blah.h not found" and having >> to tell them "well blah.h is not found. maybe you need blah?"). > As I said, only for devs and we can even make a --disable-warnings flag > that forces disabling warnings even in dev builds.
Maybe provide a --disable-warning and turn off that option when building a package version. As we already detect when we are taking the source from svn/git or a package, I think it's doable. This will provide the right option to devs without bothering people that don't understand what warning means. -- Cedric BAIL ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
