On Thu, 26 Aug 2010, Michael Jennings wrote:

> On Thursday, 26 August 2010, at 23:14:23 (+0200),
> Vincent Torri wrote:
>
>> I do not agree at all with that patch. It is hiding potential problems.
>> The double condition check is in most case a copy/paste error that needs
>> fixing instead of removal.
>>
>> Please revert it.
>
> No, that's the whole point.  Every instance that was patched needs to
> be examined and probably fixed.  Reverting it doesn't accomplish
> anything either.

that patch is NOT good, hence it should not be in. A mail showing where 
the problems are, without modifying the code in svn is far way better than 
committing something wrong.

Vincent

------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
Be part of this innovative community and reach millions of netbook users 
worldwide. Take advantage of special opportunities to increase revenue and 
speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to