On Tue, Sep 14, 2010 at 11:24 AM, Tom Hacohen <tom.haco...@partner.samsung.com> wrote: > Hey all, > > I just committed a fix to an issue with multiple tabs and text causing > text to disappear. During that fix I removed a function that looked odd > and I think that caused the problem. The function itself made 0 sense to > me, I really don't get what it was for, that's why I removed it. > > The function just runs on the items of a line searching for items > consisting of just one word and no spaces/whatever and keeps them in a > list. It stops looking once it found an item that ends with a whitespace > or one that has more than just a single word in it. > > It then splits the item to two items, the last word and the rest. > > It removes all the items it passed at the start and advances a line. In > some situations this causes an empty line and is generally just messy. > Then it adds the items again to the new line but with bad coordinates. > It's more complicated than that, but that's the idea. > > Even if this function has a purpose (which I don't think it has), it's > terribly buggy. > > I did a lot of testing trying to see if there are any new bugs after the > fix, and found nothing. > > Please if you can, check out the removed function > (_layout_walk_back_to_item_word_redo) and see if it makes any sense to > you, if it does, please let me know >
The description sounds like something used for word wrapping, but I guess you tested that's still working fine after killing it. > Revision: 52243. > > Thanks, > Tom. > > > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
