On Sun, Sep 19, 2010 at 2:07 PM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> + if (e->orientation == ETHUMB_THUMB_ORIENT_ORIGINAL)
> + {
> +#ifdef HAVE_LIBEXIF
> + ExifData *exif = exif_data_new_from_file(e->src_path);
> + ExifEntry *entry = NULL;
> + ExifByteOrder bo;
> + int o;
Missing initialization... If entry is null below, you'll use an initialized var.
> +
> + if (exif)
> + {
> + entry = exif_data_get_entry(exif, EXIF_TAG_ORIENTATION);
> + if (entry)
You might want to jump on !entry, howeve.
> + {
> + bo = exif_data_get_byte_order(exif);
> + o = exif_get_short(entry->data, bo);
> + }
> + exif_data_free(exif);
> + switch (o)
Here is the possible case of unitialized use of o.
Lucas De Marchi
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
