On Thu, Sep 23, 2010 at 9:13 AM, Carsten Haitzler <[email protected]> wrote:
> On Thu, 23 Sep 2010 08:52:30 -0300 Eduardo Felipe <[email protected]>
> said:
>
> wtf? someone.... removed the code that called it.... tasn?
>

That's actually the code about filtering input in entries that I
told you wasn't finished. You started it, added some //xx //yy //zz
marks in some places and the actual filtering never takes place.

Given the freeze, should this functions be removed now and re-added
later or we can finish the implementation?

>> Folks,
>>
>> I was looking into Edje's API yesterday when I came across these two
>> functions that seemed to do what I wanted:
>>
>> void edje_object_text_insert_filter_callback_add (Evas_Object *obj,
>> const char *part, void(*func)(void *data, Evas_Object *obj, const char
>> *part, char **text), const void *data)
>> void edje_object_text_insert_filter_callback_del (Evas_Object *obj,
>> const char *part, void(*func)(void *data, Evas_Object *obj, const char
>> *part, char **text), const void *data)
>>
>> They didn't work, so I went to the code and realized that they don't
>> actually do anything. Yes, they add/del a callback to a list of
>> callbacks, but the thing is, the callback is never called. Itens on
>> the list are manipulated and removed correctly, but the function that
>> is supposed to be calling them `static void _text_filter_prepend(...)`
>> is never called, and on later revisions received an __UNUSED__
>> attribute to shut up GCC.
>>
>> Is there a reason for this API to still exist if it's not working?
>> Shouldn't it be just removed? I can provide a patch if wanted.
>>
>>
>> Cheers,
>>
>> Eduardo Felipe.
>>
>> ------------------------------------------------------------------------------
>> Start uncovering the many advantages of virtual appliances
>> and start using them to simplify application deployment and
>> accelerate your shift to cloud computing.
>> http://p.sf.net/sfu/novell-sfdev2dev
>> _______________________________________________
>> enlightenment-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>
>
> --
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler)    [email protected]
>
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to