On Sun, 26 Sep 2010 07:26:52 +0200 (CEST) Vincent Torri <[email protected]> said:
> > > On Sun, 26 Sep 2010, Carsten Haitzler (The Rasterman) wrote: > > > On Sat, 25 Sep 2010 08:27:22 +0200 (CEST) Vincent Torri > > <[email protected]> said: > > > >> > >> > >> On Fri, 24 Sep 2010, Carsten Haitzler (The Rasterman) wrote: > >> > >>> On Fri, 24 Sep 2010 09:04:39 -0300 Iván Briano (Sachiel) > >>> <[email protected]> said: > >>> > >>>> On Fri, Sep 24, 2010 at 8:57 AM, Vincent Torri <[email protected]> > >>>> wrote: > >>>>> > >>>>> Hey, > >>>>> > >>>>> in ecore_evas, there are plenty of calls that can use Eina_Bool instead > >>>>> of int: > >>>>> > >>>>> ecore_evas_engine_type_supported_get > >>>>> ecore_evas_app_comp_sync_set > >>>>> ecore_evas_app_comp_sync_get > >>>>> all the _set functions that have an 'on' parameter and their _get too. > >>>>> > >>>>> Should we modify them before beta ? > >>>>> > >>>> > >>>> I would say yes. > >>> > >>> yes - same with the rest of ecore. want to go fix them all up before beta? > >>> as i said before - i already did evas, embryo and edje and fixed these. > >>> also moved > >>> #defines to enums too. > >> > >> I want confirmation about some points: > >> > >> 1) in Ecore_Input, some function would need int --> bool, but also > >> function type like filter_event() in Ecore_IMF_Context_Class. Can I use > >> the type Eina_Bool for the returned type of filter_event ? Same for > >> retrieve_surrounding_func() in Ecore_IMF_Context > > > > yes - looks like they can be boolean. :) > > ok, I'll do it, then. > > >> 2) all the bit fields of public and private headers can't be changed from > >> unsigned int to Eina_Bool, right ? > > > > hmm not of public ones without a more major api break. got some specific > > examples? > > i can't found any in private headers. For public, see Ecore.h for example. aaan i see - no leave them. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
