On Thu, 7 Oct 2010 18:59:08 -0400 Michael Blumenkrantz <[email protected]> said:
> I am not sure how important it is that your work is merged quickly; since > most of your work is just libcurl calls, I think it is possible that we could > merge this in time for 1.0 if it is very urgent, though I would prefer to no. this is post 1.0 - so this needs to be queued up until then. sorry. too late for 1.0 of ecore for this. the eina_bool patches sent before this should go in - mike. u want to put them in? with your return of eina_bool for success too etc. - that seems ok. it should be that way anyway. but... all the funcs for url/cookies - wait for 1.1 > hold off until you have at least written example code (which can be committed > in ecore/examples like the ecore_con ones) so that people can test more > easily. As for the function names, I have some changes to suggest: > > ecore_con_url_cookies_enable -> ecore_con_cookies_init > ecore_con_url_cookies_ignore_old_session_cookies_set -> > ecore_con_url_cookies_ignore_set ecore_con_url_cookies_clear_all -> > ecore_con_url_cookies_all_del ecore_con_url_cookies_clear_session -> > ecore_con_url_cookies_session_del ecore_con_url_cookies_load -> > ecore_con_url_cookies_file_add ecore_con_url_cookies_cookiejar_set -> > ecore_con_url_cookies_jar_file_set ecore_con_url_cookies_flush -> > ecore_con_url_cookies_jar_write > > Additionally I think it would probably be a good idea to add memory > alternatives for the file functions for situations where someone may want to > store/load cookies for manual reading in a char* or some sort of struct that > you define. Another thing to consider is that you are ignoring curl return > codes. IMO your functions should return Eina_Bool, logging errors to ERR > using curl_easy_strerror where possible (even though it may be very unlikely > that errors could occur). > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
