I was using externals in edje and i realized that some signals are not
being emitted. If you use an elm_slider, the signal SIG_DRAG_STOP is
not emitted and if you use a elm_toggle, signal SIG_CHANGED is not
emitted too.
I took a look at some code in edje and elementary and I found no
problems. But I found one bug in a function in evas that was causing
this problem.
The function evas_smart_cb_descriptions_fix (in evas_smart.c) is
always removing last element from Evas_Smart_Cb_Description_Array
(after sorting) and edje_externals use this array to emit signals.
The attached patch fixes this problem and is working fine for me. But
it is better to be reviewed for someone with more experience in evas.

Otavio Pontes
From 26bbe72b34127e8fe44469aa6048f8294ce974f5 Mon Sep 17 00:00:00 2001
From: Otavio Pontes <[email protected]>
Date: Fri, 8 Oct 2010 10:40:51 -0300
Subject: [PATCH] Fix bug in evas_smart_cb_descriptions_fix.
To: [email protected]

The last element of descriptions array was always removed.
---
 evas/src/lib/canvas/evas_smart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/evas/src/lib/canvas/evas_smart.c b/evas/src/lib/canvas/evas_smart.c
index 9a065f0..eb51640 100644
--- a/evas/src/lib/canvas/evas_smart.c
+++ b/evas/src/lib/canvas/evas_smart.c
@@ -307,7 +307,7 @@ evas_smart_cb_descriptions_fix(Evas_Smart_Cb_Description_Array *a)
 	  }
      }
 
-   evas_smart_cb_descriptions_resize(a, a->size - (j - i));
+   evas_smart_cb_descriptions_resize(a, a->size - (j - i - 1));
 }
 
 static void
-- 
1.7.3.1

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to