On Thu, 14 Oct 2010 00:21:37 -0300 Gustavo Sverzut Barbieri <[email protected]> said:
indeed. you didn't fix the bug - you "covered it up". the fact that something is accessing d->* members AFTEr d is freed is the problem. valgrind should find out where. > On Wednesday, October 13, 2010, Enlightenment SVN > <[email protected]> wrote: > > Log: > > fix annoying random segv > > > > Author: discomfitor > > Date: 2010-10-13 19:57:35 -0700 (Wed, 13 Oct 2010) > > New Revision: 53387 > > > > Modified: > > trunk/e/src/modules/everything-files/e_mod_main.c > > > > Modified: trunk/e/src/modules/everything-files/e_mod_main.c > > =================================================================== > > --- trunk/e/src/modules/everything-files/e_mod_main.c 2010-10-14 02:37:37 > > UTC (rev 53386) +++ trunk/e/src/modules/everything-files/e_mod_main.c > > 2010-10-14 02:57:35 UTC (rev 53387) @@ -177,6 +177,8 @@ > > char buf[4096]; > > Eina_Bool is_dir; > > > > + if (!d->directory) > > + return; > > d->dirp = opendir(d->directory); > > if (!d->dirp) return; > > > > @@ -342,6 +344,7 @@ > > } > > > > free(d->directory); > > + d->directory = NULL; > > E_FREE(d); > > This makes NO sense, don't do this > > > > > p->thread = NULL; > > @@ -492,6 +495,7 @@ > > } > > > > free(d->directory); > > + d->directory = NULL; > > E_FREE(d); > > p->thread = NULL; > > } > > > > > > ------------------------------------------------------------------------------ > > Beautiful is writing same markup. Internet Explorer 9 supports > > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > > Spend less time writing and rewriting code and more time creating great > > experiences on the web. Be a part of the beta today. > > http://p.sf.net/sfu/beautyoftheweb > > _______________________________________________ > > enlightenment-svn mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: [email protected] > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
