Don't see a sense here:
Notify OSD doesn't really do what we need. When you press multiple times the
volume up key, each press would generate a notification message. You end with
clustered notification messages until they disappear. What we need is a real
OSD.
Again, i change that to be optional and that's it. Let's stop that here.
On Sat, Oct 16, 2010 at 07:48:41AM -0300, Gustavo Sverzut Barbieri wrote:
> On Saturday, October 16, 2010, Brian 'morlenxus' Miculcy
> <morlen...@gmx.net> wrote:
> > Before everyone spend his time on this useless discussion - i will make this
>
> Make it use the notification, I guess we do not support gauges yet, so
> test with notify-osd, latter we can implement it
>
>
> >
> > On Sat, Oct 16, 2010 at 05:38:26AM -0300, Fabiano Fidêncio wrote:
> >> On Wed, Oct 13, 2010 at 7:36 AM, Enlightenment SVN
> >> <no-re...@enlightenment.org> wrote:
> >> > Log:
> >> > Show mixer popup when changing the volume via keybindings.
> >>
> >> Why?
> >> IMHO, this is very annoying :-\
> >>
> >> Perhaps leave that to be enabled as an option but not as default.
> >>
> >> >
> >> > Author: morlenxus
> >> > Date: 2010-10-13 03:36:04 -0700 (Wed, 13 Oct 2010)
> >> > New Revision: 53347
> >> >
> >> > Modified:
> >> > trunk/e/src/modules/mixer/e_mod_main.c
> >> > trunk/e/src/modules/mixer/e_mod_main.h
> >> >
> >> > Modified: trunk/e/src/modules/mixer/e_mod_main.c
> >> > ===================================================================
> >> > --- trunk/e/src/modules/mixer/e_mod_main.c 2010-10-13 09:34:40 UTC
> >> > (rev 53346)
> >> > +++ trunk/e/src/modules/mixer/e_mod_main.c 2010-10-13 10:36:04 UTC
> >> > (rev 53347)
> >> > @@ -486,6 +486,9 @@
> >> > inst->ui.table = NULL;
> >> > inst->ui.button = NULL;
> >> > inst->popup = NULL;
> >> > + if (inst->popup_timer)
> >> > + ecore_timer_del(inst->popup_timer);
> >> > + inst->popup_timer = NULL;
> >> > }
> >> >
> >> > static void
> >> > @@ -599,6 +602,37 @@
> >> > }
> >> >
> >> > static void
> >> > +_mixer_popup_timer_new(E_Mixer_Instance *inst)
> >> > +{
> >> > + if (inst->popup)
> >> > + {
> >> > + if (inst->popup_timer)
> >> > + {
> >> > + ecore_timer_del(inst->popup_timer);
> >> > + inst->popup_timer = ecore_timer_add(1.0,
> >> > _mixer_popup_timer_cb, inst);
> >> > + }
> >> > + }
> >> > + else
> >> > + {
> >> > + _mixer_popup_new(inst);
> >> > + inst->popup_timer = ecore_timer_add(1.0, _mixer_popup_timer_cb,
> >> > inst);
> >> > + }
> >> > +}
> >> > +
> >> > +static Eina_Bool
> >> > +_mixer_popup_timer_cb(void *data)
> >> > +{
> >> > + E_Mixer_Instance *inst;
> >> > + inst = data;
> >> > +
> >> > + if (inst->popup)
> >> > + _mixer_popup_del(inst);
> >> > + inst->popup_timer = NULL;
> >> > +
> >> > + return ECORE_CALLBACK_CANCEL;
> >> > +}
> >> > +
> >> > +static void
> >> > _mixer_menu_cb_post(void *data, E_Menu *menu __UNUSED__)
> >> > {
> >> > E_Mixer_Instance *inst = data;
> >> > @@ -978,8 +1012,12 @@
> >> > if (!ctxt->conf)
> >> > return;
> >> >
> >> > - if (ctxt->default_instance)
> >> > - _mixer_volume_increase(ctxt->default_instance);
> >> > +
> >> > + if (!ctxt->default_instance)
> >> > + return;
> >> > +
> >> > + _mixer_popup_timer_new(ctxt->default_instance);
> >> > + _mixer_volume_increase(ctxt->default_instance);
> >> > }
> >> >
> >> > static void
> >> > @@ -994,8 +1032,11 @@
> >> > if (!ctxt->conf)
> >> > return;
> >> >
> >> > - if (ctxt->default_instance)
> >> > - _mixer_volume_decrease(ctxt->default_instance);
> >> > + if (!ctxt->default_instance)
> >> > + return;
> >> > +
> >> > + _mixer_popup_timer_new(ctxt->default_instance);
> >> > + _mixer_volume_decrease(ctxt->default_instance);
> >> > }
> >> >
> >> > static void
> >> > @@ -1010,8 +1051,11 @@
> >> > if (!ctxt->conf)
> >> > return;
> >> >
> >> > - if (ctxt->default_instance)
> >> > -
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
>
> ------------------------------------------------------------------------------
> Download new Adobe(R) Flash(R) Builder(TM) 4
> The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
> Flex(R) Builder(TM)) enable the development of rich applications that run
> across multiple browsers and platforms. Download your free trials today!
> http://p.sf.net/sfu/adobe-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
