On Tue, Oct 19, 2010 at 8:48 AM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
> Log:
> elm_diskpicker: save (list_len - 3) strlen calls
>
> demarchi-- for reducing performance just to solve a comparison between
> signed and unsigned.
>
>
> Author: bdilly
> Date: 2010-10-19 03:48:11 -0700 (Tue, 19 Oct 2010)
> New Revision: 53591
>
> Modified:
> trunk/TMP/st/elementary/src/lib/elm_diskpicker.c
>
> Modified: trunk/TMP/st/elementary/src/lib/elm_diskpicker.c
> ===================================================================
> --- trunk/TMP/st/elementary/src/lib/elm_diskpicker.c 2010-10-19 05:58:26
> UTC (rev 53590)
> +++ trunk/TMP/st/elementary/src/lib/elm_diskpicker.c 2010-10-19 10:48:11
> UTC (rev 53591)
> @@ -388,13 +388,15 @@
>
> EINA_LIST_FOREACH(list, l, it)
> {
> - int len = strlen(it->label);
> Evas_Coord x, w;
> + int len;
> evas_object_geometry_get(it->base.view, &x, NULL, &w, NULL);
> /* item not visible */
> if (x + w <= ox || x >= ox + ow)
> continue;
>
> + len = strlen(it->label);
likely what's in an internal item should be stringshared, then
eina_stringshare_strlen() is O(1) :-)
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
