On Tue, Nov 16, 2010 at 11:02 PM, Daniel Juyung Seo <[email protected]> wrote: > Hello, > I have a patch for genlist. > > 1. elm_genlist_item_item_class_update() API > It is required to change an item's item class on run-time. > Applications want to change a certain item's style and callbacks > dynamically. > This looks ok because changing one item's style does not affect performance, > And this API uses elm_genlist_item_update internally. > API name follows elementary naming conventions. > I've also added test code to elementary_test, Genlist 7.
Looks good! Just make the item class constant: elm_genlist_item_item_class_update(Elm_Genlist_Item *it, const Elm_Genlist_Item_Class *itc) > 2. constant to macro. > I replaced 2 constants for max_item_per_block and longpress_timeout to > macros. > This could be used in other places of the code. > > 3. duplicated assignment. > In elm_genlist_item_append, it->before = 0 is written in if and else. > I put this statement out of if(). > > 4. fix doxygen typo > I fixed elm_genlist_compress_mode_set doxygen. seems fine as well. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today http://p.sf.net/sfu/msIE9-sfdev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
