Hello, anyhow this is a good trial. Due to 'clicked' is changed recently by Raster, we can adopt this changes to other widgets as well. It's time to rock!
Daniel Juyung Seo. On Wed, Nov 24, 2010 at 11:34 PM, Bruno Dilly <[email protected]> wrote: > On Wed, Nov 24, 2010 at 11:44 AM, WooHyun Jung <[email protected]> > wrote: >> Hello. I'm WooHyun Jung. >> >> >> >> I modified some codes of elm_colorselector.c . > > Hey WooHyun, > > would you matter to explain me why are you proposing the following > change, please? > > @@ -604,9 +635,25 @@ _add_colorbar(Evas_Object *obj) > wd->cp[i] = ELM_NEW(Colorselector_Data); > > wd->cp[i]->parent = obj; > - wd->cp[i]->colorselector_num = i; > - > - /* load colorbar area */ > + wd->cp[i]->color_type = i; > + switch(i) > + { > + case 0 : > + wd->cp[i]->color_type = HUE; > + break; > + case 1 : > + wd->cp[i]->color_type = SATURATION; > + break; > + case 2 : > + wd->cp[i]->color_type = LIGHTNESS; > + break; > + case 3 : > + wd->cp[i]->color_type = ALPHA; > + break; > + default : > + break; > + } > + /* load colorbar area */ > > It's insider a for (i = 0; i < 4; i++). > Basically you are doing > wd->cp[0]->color_type = 0; > then "i" will match case 0 and: > wd->cp[0]->color_type = 0 (HUE) once again... > > Or maybe I'm missing something. > >> >> And , for about elm_entry.c , I thought that "SIG_CLICKED" was wrongly >> emitted (by "MOUSE_UP" event). > > If you are proposing to use _signal_mouse_clicked instead of > _signal_mouse_up your patch should remove this function. Don't leave > dead code, please. > > Thank you > >> >> So I changed it. >> >> >> >> Please check attached patch file. >> >> Thanks. >> >> >> ------------------------------------------------------------------------------ >> Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! >> Tap into the largest installed PC base & get more eyes on your game by >> optimizing for Intel(R) Graphics Technology. Get started today with the >> Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. >> http://p.sf.net/sfu/intelisp-dev2dev >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> > > ------------------------------------------------------------------------------ > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > Tap into the largest installed PC base & get more eyes on your game by > optimizing for Intel(R) Graphics Technology. Get started today with the > Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. > http://p.sf.net/sfu/intelisp-dev2dev > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
