On Wed, 1 Dec 2010 03:35:09 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> said:
> Dear all, I have a patch for some issues. > Anybody can review this patch and apply this to upstream? > > [Genlist] > 1. fixed elm_genlist_item_display_only_set() API bug. > "elm,state,selected" signal should not be emitted when display_only is set. > display_only was not set properly when it->block did not exist. good. cool. > 2. Add a macro for SWIPE_TIMEOUT > Instead of using constant "0.4" for swipe timer in the middle of > code, I added a macro SWIPE_TIMEOUT. issue here. could you actually make this an elm config value? so its in system config, it's loaded at start and can be configured by elm's config tool? (well not now, but in the future). resubmit patch then? don't forget config version and to upgrade it and handle the upgrade - examples in the code how to do that already :) > 3. Indentation and space fix. > I fixed indentations for item cache and some other lines. > I removed some unnecessary spaces. ok. so just the above :) > [List] > 1. Add macros for SWIPE_TIMEOUT and LONGPRESS_TIMEOUT > Instead of using constants in the middle of code, I added macros. > > Thanks. > Daniel Juyung Seo. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
