> +/* Why do this? Well PATH_MAX may vary from when eina itself is compiled > + * to when the app using eina is compiled. exposing the path buffer > below > + * cant safely and portably vary based on how/when you compile. it > should > + * always be the same for both eina inside ANd for apps outside that use > eina > + * so define this ti 8192 minus ther other struct bits so that > + * Eina_File_Direct_Info can take a nice round 2 pages. */ > +#define EINA_PATH_MAX (8192 - (sizeof(size_t) * 3) - > sizeof(Eina_File_Type))
Doesn't this logic only make sense if: - You use external tracking for your mallocs, or - You use a pool allocator? Since neither is true in the general case you've just made EINA_PATH_MAX incompatible with every path max on the planet, in return for a gain that will won't happen for anyway. Considering the only time it's used is INSIDE another structure... There is never a gain. So the result is more complex, always incompatible, and never a gain. Regards, nash ------------------------------------------------------------------------------ This SF Dev2Dev email is sponsored by: WikiLeaks The End of the Free Internet http://p.sf.net/sfu/therealnews-com _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
