On Thu, 16 Dec 2010 08:50:07 +0100 (CET) Vincent Torri <[email protected]>
said:

> 
> 
> On Thu, 16 Dec 2010, Sebastian Dransfeld wrote:
> 
> > Hi,
> >
> > This shouldn't be there. It is the users responisbility to pass the
> > right name. Otherwise you need to add ftp://, imap:// etc. ad infinitum.
> 
> and the documentation should mention that it's up to the user to provide 
> the correct name

it already is documented that way. discomfitor just didn't read the docs. :)

> >
> > Sebastian
> >
> > On 12/16/2010 06:13 AM, Enlightenment SVN wrote:
> >> Log:
> >> validate name better, fix super frustrating bug where connections would
> >> inexplicably die if prefixed with http[s]://
> >>
> >>
> >> Author:       discomfitor
> >> Date:         2010-12-15 21:13:29 -0800 (Wed, 15 Dec 2010)
> >> New Revision: 55573
> >> Trac:         http://trac.enlightenment.org/e/changeset/55573
> >>
> >> Modified:
> >>    trunk/ecore/src/lib/ecore_con/ecore_con.c
> >>
> >> Modified: trunk/ecore/src/lib/ecore_con/ecore_con.c
> >> ===================================================================
> >> --- trunk/ecore/src/lib/ecore_con/ecore_con.c      2010-12-16 04:40:14
> >> UTC (rev 55572) +++ trunk/ecore/src/lib/ecore_con/ecore_con.c
> >> 2010-12-16 05:13:29 UTC (rev 55573) @@ -425,7 +425,7 @@
> >>      Ecore_Con_Server *svr;
> >>      Ecore_Con_Type type;
> >>
> >> -   if (!name)
> >> +   if ((!name) || (!name[0]))
> >>        return NULL;
> >>      /* local  user   socket: FILE:   ~/.ecore/[name]/[port] */
> >>      /* local  system socket: FILE:   /tmp/.ecore_service|[name]|[port] */
> >> @@ -434,6 +434,10 @@
> >>      if (!svr)
> >>        return NULL;
> >>
> >> +   if (!strncmp(name, "http://";, 7))
> >> +     name += 7;
> >> +   else if (!strncmp(name, "https://";, 8))
> >> +     name += 8;
> >>      svr->name = strdup(name);
> >>      if (!svr->name)
> >>        goto error;
> >>
> >>
> >> ------------------------------------------------------------------------------
> >> Lotusphere 2011
> >> Register now for Lotusphere 2011 and learn how
> >> to connect the dots, take your collaborative environment
> >> to the next level, and enter the era of Social Business.
> >> http://p.sf.net/sfu/lotusphere-d2d
> >> _______________________________________________
> >> enlightenment-svn mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
> >
> > ------------------------------------------------------------------------------
> > Lotusphere 2011
> > Register now for Lotusphere 2011 and learn how
> > to connect the dots, take your collaborative environment
> > to the next level, and enter the era of Social Business.
> > http://p.sf.net/sfu/lotusphere-d2d
> > _______________________________________________
> > enlightenment-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
> 
> ------------------------------------------------------------------------------
> Lotusphere 2011
> Register now for Lotusphere 2011 and learn how
> to connect the dots, take your collaborative environment
> to the next level, and enter the era of Social Business.
> http://p.sf.net/sfu/lotusphere-d2d
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    [email protected]


------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to