On 12/20/2010 12:15 AM, Mike Blumenkrantz wrote: > On Sun, 19 Dec 2010 23:19:47 -0500 > Christopher Michael<cpmicha...@comcast.net> wrote: > >> On 12/19/2010 05:06 PM, Mike Blumenkrantz wrote: >>> On Sun, 19 Dec 2010 13:36:28 -0800 >>> "Enlightenment SVN"<no-re...@enlightenment.org> wrote: >>> >>>> Log: >>>> fixes a segv when trying to add systray gadget to desktop; someone who >>>> knows gadman module please review! >>>> >>>> Author: discomfitor >>>> Date: 2010-12-19 13:36:27 -0800 (Sun, 19 Dec 2010) >>>> New Revision: 55647 >>>> Trac: http://trac.enlightenment.org/e/changeset/55647 >>>> >>>> Modified: >>>> trunk/e/src/modules/gadman/e_mod_config.c >>>> >>>> Modified: trunk/e/src/modules/gadman/e_mod_config.c >>>> =================================================================== >>>> --- trunk/e/src/modules/gadman/e_mod_config.c 2010-12-19 19:19:33 >>>> UTC (rev 55646) +++ trunk/e/src/modules/gadman/e_mod_config.c >>>> 2010-12-19 21:36:27 UTC (rev 55647) @@ -333,7 +333,7 @@ >>>> if (!cc) continue; >>>> >>>> gcc = gadman_gadget_add(cc, GADMAN_LAYER_BG); >>>> - gadman_gadget_edit_start(gcc); >>>> + if (gcc) gadman_gadget_edit_start(gcc); >>>> } >>>> >>>> if (l) eina_list_free(l); >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Lotusphere 2011 >>>> Register now for Lotusphere 2011 and learn how >>>> to connect the dots, take your collaborative environment >>>> to the next level, and enter the era of Social Business. >>>> http://p.sf.net/sfu/lotusphere-d2d >>>> _______________________________________________ >>>> enlightenment-svn mailing list >>>> enlightenment-...@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >>> I don't know the module so I don't know how to debug it, but this prevents a >>> crash which occurs while trying to add a gadget to desktop (I used systray >>> to cause the bug, but probably all of them work?). Currently, all this >>> does is avoid the crash; the gadget will not be added. This is obviously >>> not the right fix, but at least it won't crash all over :) >>> >> >> That 'fix' is fine. What needs doing is this: This 'bug' happens because >> some modules only want once instance. A second instance, then their code >> barfs :( The rest of the gadcon code isn't exactly prepared for this >> situation....Systray is Notorious for this (90-98% of the time) !!! >> Also, keep digging and you will find a couple other 'instances' where >> this same situation happens in similar code .... >> >> Once cannot assume that "just because you 'tried' to load a module" >> means that it loaded...... >> >> dh >> >> > Oh joy. I guess I'll file a bug on trac then since I don't know enough about > e > to fix it and don't have time to learn right now :( > No worries. I'll add it to the 'things todo when I am totally bored' list ;)
dh -- "If C gives you enough rope to hang yourself, then C++ gives you enough rope to bind and gag your neighborhood, rig the sails on a small ship, and still have enough rope to hang yourself from the yardarm" - Anonymous quote from the The UNIX-HATERS Handbook ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
