On Wed, 22 Dec 2010 18:01:10 -0500 Christopher Michael <[email protected]> wrote:
> This is fine. It just checks to make sure we have a border from the > border hook function. In theory, it should always pass a border to us > from the border hook function, BUT a little safety never hurts ;) > > dh > > On 12/22/2010 05:45 PM, Enlightenment SVN wrote: > > Log: > > add pondering comment, fix what appears to be a bug? please check, o ye > > lords of illume > > > > > > Author: discomfitor > > Date: 2010-12-22 14:45:26 -0800 (Wed, 22 Dec 2010) > > New Revision: 55705 > > Trac: http://trac.enlightenment.org/e/changeset/55705 > > > > Modified: > > trunk/e/src/modules/illume/e_kbd.c > > > > Modified: trunk/e/src/modules/illume/e_kbd.c > > =================================================================== > > --- trunk/e/src/modules/illume/e_kbd.c 2010-12-22 22:41:26 UTC (rev > > 55704) +++ trunk/e/src/modules/illume/e_kbd.c 2010-12-22 22:45:26 > > UTC (rev 55705) @@ -514,7 +514,7 @@ > > E_Kbd *kbd; > > int pbx, pby, pbw, pbh; > > > > - if (!(bd = data2)) return; > > + if (!(bd = data2)) return; /* is there a point to this? */ > > kbd = _e_kbd_by_border_get(bd); > > if (!kbd) return; > > > > @@ -543,7 +543,7 @@ > > bd->client.icccm.take_focus = 0; > > > > bd->w = bd->zone->w; > > - bd->h = bd->h; > > + bd->h = bd->zone->h; > > bd->x = bd->zone->x; > > bd->y = bd->zone->y + bd->zone->h - bd->h; > > > > > > > ahhh I see, so it's a null check and assignment at the same time. I was thinking that it was checking to see if the value was actually getting assigned for some reason haha -- Mike Blumenkrantz Zentific: We run the three-legged race individually. ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
