On Fri, 7 Jan 2011 17:01:21 +0100 (CET) Vincent Torri <vto...@univ-evry.fr> said:
> > > On Fri, 7 Jan 2011, Enlightenment SVN wrote: > > > Log: > > hve to revert these commits. they hve created a whole chunk of 64bit > > crashes on linux. this is REALLY bad. so remove these changes now. > > I have tested them on my 64 bits ubuntu. > > You can't seriously say that these commits can crash the EFL. It's just a > matter of macro defined in config.h ! Look at the patches ! i can. they do. e17 literally ceased to begin - crash in ecore_file_dir_get() revert and presto - works again. i suspect its one or more of the headers not being detected and included and thus prototypes not being defined properly - the only thing that would make sense, but i'm not kidding - it really does cause e to crash instantly on start - it doesnt even get past some first few inits. revert your changes and it works again - i reverted all the similar changes too just for safety. > Vincent > > > > > > > > > Author: raster > > Date: 2011-01-07 07:56:54 -0800 (Fri, 07 Jan 2011) > > New Revision: 55981 > > Trac: http://trac.enlightenment.org/e/changeset/55981 > > > > Modified: > > trunk/ecore/configure.ac trunk/ecore/src/lib/ecore/ecore.c > > trunk/ecore/src/lib/ecore/ecore_app.c > > trunk/ecore/src/lib/ecore/ecore_main.c > > trunk/ecore/src/lib/ecore_file/ecore_file.c trunk/eet/configure.ac > > trunk/eet/src/lib/eet_cipher.c trunk/eet/src/lib/eet_lib.c > > trunk/eina/configure.ac trunk/eina/src/lib/eina_hash.c > > trunk/eina/src/lib/eina_log.c trunk/eina/src/lib/eina_module.c > > trunk/evas/src/lib/canvas/evas_async_events.c > > trunk/evas/src/lib/file/evas_path.c trunk/evas/src/lib/include/evas_common.h > > > > Modified: trunk/ecore/configure.ac > > =================================================================== > > --- trunk/ecore/configure.ac 2011-01-07 12:57:06 UTC (rev 55980) > > +++ trunk/ecore/configure.ac 2011-01-07 15:56:54 UTC (rev 55981) > > @@ -889,7 +889,7 @@ > > have_addrinfo="yes" > > ;; > > *) > > - AC_CHECK_HEADERS([dlfcn.h features.h langinfo.h locale.h sys/time.h > > sys/mman.h signal.h sys/resource.h sys/param.h unistd.h libgen]) > > + AC_CHECK_HEADERS([dlfcn.h features.h langinfo.h locale.h sys/time.h > > sys/mman.h signal.h sys/resource.h]) ;; > > esac > > > > > > Modified: trunk/ecore/src/lib/ecore/ecore.c > > =================================================================== > > --- trunk/ecore/src/lib/ecore/ecore.c 2011-01-07 12:57:06 UTC (rev > > 55980) +++ trunk/ecore/src/lib/ecore/ecore.c 2011-01-07 15:56:54 UTC > > (rev 55981) @@ -8,7 +8,7 @@ > > #include <fcntl.h> > > #include <errno.h> > > > > -#ifdef HAVE_UNISTD_H > > +#ifndef _MSC_VER > > # include <unistd.h> > > #endif > > > > @@ -27,7 +27,6 @@ > > #ifdef HAVE_EVIL > > # include <Evil.h> > > #endif > > - > > #include <Eina.h> > > > > #include "Ecore.h" > > > > Modified: trunk/ecore/src/lib/ecore/ecore_app.c > > =================================================================== > > --- trunk/ecore/src/lib/ecore/ecore_app.c 2011-01-07 12:57:06 UTC > > (rev 55980) +++ trunk/ecore/src/lib/ecore/ecore_app.c 2011-01-07 > > 15:56:54 UTC (rev 55981) @@ -4,11 +4,9 @@ > > > > #include <stdlib.h> > > > > -#ifdef HAVE_UNISTD_H > > +#ifndef _MSC_VER > > # include <unistd.h> > > -#endif > > - > > -#ifdef _MSC_VER > > +#else > > # include <process.h> > > #endif > > > > > > Modified: trunk/ecore/src/lib/ecore/ecore_main.c > > =================================================================== > > --- trunk/ecore/src/lib/ecore/ecore_main.c 2011-01-07 12:57:06 UTC > > (rev 55980) +++ trunk/ecore/src/lib/ecore/ecore_main.c 2011-01-07 > > 15:56:54 UTC (rev 55981) @@ -23,22 +23,17 @@ > > #include <errno.h> > > #include <fcntl.h> > > > > -#ifdef HAVE_SYS_TIME_H > > +#ifndef _MSC_VER > > # include <sys/time.h> > > -#endif > > - > > -#ifdef HAVE_UNISTD_H > > # include <unistd.h> > > -#endif > > - > > -#ifdef _MSC_VER > > +#else > > # include <float.h> > > #endif > > > > #define FIX_HZ 1 > > > > #ifdef FIX_HZ > > -# ifdef HAVE_SYS_PARAM_H > > +# ifndef _MSC_VER > > # include <sys/param.h> > > # endif > > # ifndef HZ > > @@ -50,6 +45,9 @@ > > # include <Evil.h> > > #endif > > > > +#include "Ecore.h" > > +#include "ecore_private.h" > > + > > #ifdef HAVE_SYS_EPOLL_H > > # define HAVE_EPOLL > > # include <sys/epoll.h> > > @@ -59,9 +57,6 @@ > > # include <glib.h> > > #endif > > > > -#include "Ecore.h" > > -#include "ecore_private.h" > > - > > struct _Ecore_Fd_Handler > > { > > EINA_INLIST; > > > > Modified: trunk/ecore/src/lib/ecore_file/ecore_file.c > > =================================================================== > > --- trunk/ecore/src/lib/ecore_file/ecore_file.c 2011-01-07 12:57:06 > > UTC (rev 55980) +++ trunk/ecore/src/lib/ecore_file/ecore_file.c > > 2011-01-07 15:56:54 UTC (rev 55981) @@ -5,18 +5,14 @@ > > #include <stdio.h> > > #include <string.h> > > > > -#ifdef HAVE_UNISTD_H > > +#ifndef _MSC_VER > > # include <unistd.h> > > -#endif > > - > > -#ifdef HAVE_LIBGEN_H > > # include <libgen.h> > > #endif > > > > #ifdef HAVE_FEATURES_H > > # include <features.h> > > #endif > > - > > #include <ctype.h> > > #include <errno.h> > > > > > > Modified: trunk/eet/configure.ac > > =================================================================== > > --- trunk/eet/configure.ac 2011-01-07 12:57:06 UTC (rev 55980) > > +++ trunk/eet/configure.ac 2011-01-07 15:56:54 UTC (rev 55981) > > @@ -352,7 +352,7 @@ > > [dummy="yes"], > > [AC_MSG_ERROR("Cannot find jpeglib.h. Make sure your CFLAGS environment > > variable contains include lines for the location of this file")]) > > > > -AC_CHECK_HEADERS([netinet/in.h unistd.h]) > > +AC_CHECK_HEADERS(netinet/in.h) > > EFL_CHECK_PATH_MAX > > > > ### Checks for types > > > > Modified: trunk/eet/src/lib/eet_cipher.c > > =================================================================== > > --- trunk/eet/src/lib/eet_cipher.c 2011-01-07 12:57:06 UTC (rev > > 55980) +++ trunk/eet/src/lib/eet_cipher.c 2011-01-07 15:56:54 UTC > > (rev 55981) @@ -25,9 +25,9 @@ > > #include <sys/stat.h> > > #include <sys/mman.h> > > > > -#ifdef HAVE_UNISTD_H > > +#ifndef _MSC_VER > > # include <unistd.h> > > -#endif > > +#endif /* ifndef _MSC_VER */ > > > > #ifdef HAVE_NETINET_IN_H > > # include <netinet/in.h> > > > > Modified: trunk/eet/src/lib/eet_lib.c > > =================================================================== > > --- trunk/eet/src/lib/eet_lib.c 2011-01-07 12:57:06 UTC (rev 55980) > > +++ trunk/eet/src/lib/eet_lib.c 2011-01-07 15:56:54 UTC (rev 55981) > > @@ -34,9 +34,9 @@ > > #include <fcntl.h> > > #include <zlib.h> > > > > -#ifdef HAVE_UNISTD_H > > +#ifndef _MSC_VER > > # include <unistd.h> > > -#endif > > +#endif /* ifndef _MSC_VER */ > > > > #ifdef HAVE_NETINET_IN_H > > # include <netinet/in.h> > > > > Modified: trunk/eina/configure.ac > > =================================================================== > > --- trunk/eina/configure.ac 2011-01-07 12:57:06 UTC (rev 55980) > > +++ trunk/eina/configure.ac 2011-01-07 15:56:54 UTC (rev 55981) > > @@ -330,7 +330,6 @@ > > AC_HEADER_ASSERT > > AC_HEADER_DIRENT > > AC_HEADER_TIME > > -AC_CHECK_HEADERS([unistd.h libgen.h]) > > EFL_CHECK_PATH_MAX > > > > ### Checks for types > > > > Modified: trunk/eina/src/lib/eina_hash.c > > =================================================================== > > --- trunk/eina/src/lib/eina_hash.c 2011-01-07 12:57:06 UTC (rev > > 55980) +++ trunk/eina/src/lib/eina_hash.c 2011-01-07 15:56:54 UTC > > (rev 55981) @@ -24,13 +24,10 @@ > > #include <stdio.h> > > #include <stdlib.h> > > #include <string.h> > > - > > -#ifdef HAVE_STDINT_H > > -# include <stdint.h> > > -#endif > > - > > #ifdef _MSC_VER > > # include <Evil.h> > > +#else > > +# include <stdint.h> > > #endif > > > > #include "eina_config.h" > > > > Modified: trunk/eina/src/lib/eina_log.c > > =================================================================== > > --- trunk/eina/src/lib/eina_log.c 2011-01-07 12:57:06 UTC (rev 55980) > > +++ trunk/eina/src/lib/eina_log.c 2011-01-07 15:56:54 UTC (rev 55981) > > @@ -268,7 +268,7 @@ > > #include <assert.h> > > #include <errno.h> > > > > -#ifdef HAVE_UNISTD_H > > +#ifndef _MSC_VER > > # include <unistd.h> > > #endif > > > > > > Modified: trunk/eina/src/lib/eina_module.c > > =================================================================== > > --- trunk/eina/src/lib/eina_module.c 2011-01-07 12:57:06 UTC (rev > > 55980) +++ trunk/eina/src/lib/eina_module.c 2011-01-07 15:56:54 UTC > > (rev 55981) @@ -42,8 +42,10 @@ > > #include <dirent.h> > > #include <string.h> > > > > -#ifdef HAVE_LIBGEN_H > > +#ifndef _MSC_VER > > # include <libgen.h> > > +#else > > +# include <Evil.h> > > #endif > > > > #include <dlfcn.h> > > > > Modified: trunk/evas/src/lib/canvas/evas_async_events.c > > =================================================================== > > --- trunk/evas/src/lib/canvas/evas_async_events.c 2011-01-07 > > 12:57:06 UTC (rev 55980) +++ > > trunk/evas/src/lib/canvas/evas_async_events.c 2011-01-07 15:56:54 > > UTC (rev 55981) @@ -3,11 +3,9 @@ > > > > #ifdef BUILD_ASYNC_EVENTS > > > > - > > -#ifdef HAVE_UNISTD_H > > +#ifndef _MSC_VER > > # include <unistd.h> > > #endif > > - > > #include <fcntl.h> > > #include <errno.h> > > > > > > Modified: trunk/evas/src/lib/file/evas_path.c > > =================================================================== > > --- trunk/evas/src/lib/file/evas_path.c 2011-01-07 12:57:06 UTC (rev > > 55980) +++ trunk/evas/src/lib/file/evas_path.c 2011-01-07 15:56:54 > > UTC (rev 55981) @@ -14,12 +14,8 @@ > > /* get the casefold feature! */ > > #include <fnmatch.h> > > #include <dirent.h> > > - > > -#ifdef HAVE_UNISTD_H > > +#ifndef _MSC_VER > > # include <unistd.h> > > -#endif > > - > > -#ifndef HAVE_SYS_PARAM_H > > # include <sys/param.h> > > #endif > > > > > > Modified: trunk/evas/src/lib/include/evas_common.h > > =================================================================== > > --- trunk/evas/src/lib/include/evas_common.h 2011-01-07 12:57:06 UTC > > (rev 55980) +++ trunk/evas/src/lib/include/evas_common.h 2011-01-07 > > 15:56:54 UTC (rev 55981) @@ -242,14 +242,10 @@ > > #include <time.h> > > #include <ctype.h> > > > > -#ifdef HAVE_STDINT_H > > +#ifndef _MSC_VER > > # include <stdint.h> > > #endif > > > > -#ifdef HAVE_UNISTD_H > > -# include <unistd.h> > > -#endif > > - > > #include <ft2build.h> > > #include FT_FREETYPE_H > > #include FT_GLYPH_H > > > > > > ------------------------------------------------------------------------------ > > Gaining the trust of online customers is vital for the success of any > > company that requires sensitive data to be transmitted over the Web. > > Learn how to best implement a security strategy that keeps consumers' > > information secure and instills the confidence they need to proceed with > > transactions. http://p.sf.net/sfu/oracle-sfdevnl > > _______________________________________________ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > > > > ------------------------------------------------------------------------------ > Gaining the trust of online customers is vital for the success of any company > that requires sensitive data to be transmitted over the Web. Learn how to > best implement a security strategy that keeps consumers' information secure > and instills the confidence they need to proceed with transactions. > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
