On Fri, 14 Jan 2011 03:58:58 -0800 "Enlightenment SVN" <[email protected]> wrote:
> Log: > BAD DISCOMFITOR! BROKE ecore_exe! > > > > Author: raster > Date: 2011-01-14 03:58:58 -0800 (Fri, 14 Jan 2011) > New Revision: 56110 > Trac: http://trac.enlightenment.org/e/changeset/56110 > > Modified: > trunk/ecore/src/lib/ecore/ecore_exe.c > > Modified: trunk/ecore/src/lib/ecore/ecore_exe.c > =================================================================== > --- trunk/ecore/src/lib/ecore/ecore_exe.c 2011-01-14 11:19:30 UTC (rev > 56109) +++ trunk/ecore/src/lib/ecore/ecore_exe.c 2011-01-14 11:58:58 > UTC (rev 56110) @@ -1500,14 +1500,6 @@ > } > } > > - if ((!args) || (!args[0])) > - { > - IF_FREE(buf); > - IF_FREE(args); > - ERR("arg[0] is NULL!"); > - return; > - } > - > if (!(flags & ECORE_EXE_NOT_LEADER)) setsid(); > if ((flags & ECORE_EXE_USE_SH)) > { > @@ -1527,6 +1519,13 @@ > } > else > { /* We can run this directly. */ > + if (!args) > + { > + IF_FREE(buf); > + IF_FREE(args); > + ERR("arg[0] is NULL!"); > + return; > + } > errno = 0; > execvp(args[0], args); > } > > all those random commits and I only broke two things. not bad. not bad at all. -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
