Hi, thanks for reporting. I've fixed some stuff in itask-ng and no more 'restart' is required on any config changes. If you find remaining or new issues please let me know.
BR On Thu, Jan 20, 2011 at 3:34 AM, Nikolas Arend <[email protected]> wrote: > Hi, > > Attached below is a small itask-ng patch against ng_config.c. It adds the > imho missing stacking config entry, which kept messing up my itask-ng module > configuration. > > While looking at this, I noticed two things: > > - throughout the itask-ng code, function parameters (pointers) are assumed > to be non-NULL but never checked before accessed or assigned. In the > situation that the missing config entry created this led to a segfault > instead of proper recovery. I'm talking about the following code in > ng_config.c > > if (ci->stacking != cfdata->stacking) > { > restart = 1; > goto end; > } > > and the subsequent restart procedure (i.e. ng_free()). > > - the if(restart) part in ng_config() mentioned above does not seem to be > recovering things properly. If e.g. the above check with respect to stacking > fails, then it should restore the config and apply default parameters, I > guess? It is not doing this for me. > > > I can probably come up with patches for both (certainly for the first > issue), but maybe others who know the code better would be more efficient. > > > > Best, Nick. > > ------------------------------------------------------------------------------ > Protect Your Site and Customers from Malware Attacks > Learn about various malware tactics and how to avoid them. Understand > malware threats, the impact they can have on your business, and how you > can protect your company and customers by using code signing. > http://p.sf.net/sfu/oracle-sfdevnl > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
