On 01/25/2011 12:10 PM, Lucas De Marchi wrote: > On Mon, Jan 24, 2011 at 9:56 AM, Mike McCormack > <mj.mccorm...@samsung.com> wrote: >> >> The way ecore handles signals is racy. >> The attached patch uses a pipe to avoid races between signals and >> select/poll(). > > Couldn't we use signalfd instead? It's the most clean way I know.
Clean, but not portable, as I understand. I could add it with a fallback to the pipe method. There's actually quite a bit of cleaning up to do for ecore signal handling. I'm not even sure that it's a good idea for a library (or framework) to be messing with signal handlers without an explicit request from the application using it. >> A fix for before or after 1.0...? > > After, for sure. I agree. Was testing the general consensus. Will queue this and work on cleaning up the rest of it. thanks, Mike ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
