Dear WooHyun, I haven't really reviewed the patch because I really don't know enough about elementary's modules. But I did manage to spot a couple of issues that mean that the patch can't be accepted:
1. line 15 of the patch: "if (_elm_module_load(m) == EINA_FALSE)" should be "if (!_elm_module_load(m))". 2. there's wrong indentation in all of _elm_module_load As I said, I haven't even looked at the content, just a went over the styling, which as I said, does not comply. Please fix those and send a new patch. For more info about the e coding style, please check this page: http://trac.enlightenment.org/e/wiki/ECoding Thanks a lot, Tom. On Tue, 2011-01-25 at 14:46 +0900, WooHyun Jung wrote: > Hello. > > Mr. Wonguk Jeong made a patch for elm_module. > > This patch is for changing the timing of module loading. > > > > For now, module loading is done in elm_init > > Thus, modules are always loaded, even if the application does not use them. > > > > So this patch deferred the timing of module loading to > "_elm_module_find_as". > > > > Can anyone check about this ? > > Thanks. > > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ enlightenment-devel mailing > list [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
