On Tue, 25 Jan 2011 22:56:06 +0100 (CET) Vincent Torri <[email protected]> wrote:
> > > On Tue, 25 Jan 2011, Enlightenment SVN wrote: > > > Log: > > propery call eina_init/ecore_init and eina_shutdown/ecore_shutdown() here > > to avoid some logging errors and whatnot > > > > > > Author: discomfitor > > Date: 2011-01-25 12:22:50 -0800 (Tue, 25 Jan 2011) > > New Revision: 56301 > > Trac: http://trac.enlightenment.org/e/changeset/56301 > > > > Modified: > > trunk/e_dbus/src/bin/notify-send.c trunk/e_dbus/src/lib/dbus/e_dbus.c > > > > Modified: trunk/e_dbus/src/bin/notify-send.c > > =================================================================== > > --- trunk/e_dbus/src/bin/notify-send.c 2011-01-25 18:20:13 UTC (rev > > 56300) +++ trunk/e_dbus/src/bin/notify-send.c 2011-01-25 20:22:50 > > UTC (rev 56301) @@ -80,6 +80,8 @@ > > int print_id = 0; > > E_Notification *n; > > > > + eina_init(); > > + ecore_init(); > > e_notification_init(); > > n = e_notification_new(); > > e_notification_app_name_set(n, "e-notify-send"); > > @@ -170,6 +172,8 @@ > > > > e_notification_unref(n); > > e_notification_shutdown(); > > + ecore_shutdown(); > > + eina_shutdown(); > > i don't understand why it is needed. Can you explain ? Apparently it was causing some kind of log domain errors at times. > > > } > > > > + if (!ecore_init()) > > + { > > + fprintf(stderr,"E-dbus: Enable to initialize ecore\n"); > > + eina_shutdown(); > > + return --_edbus_init_count; > > + } > > you should init ecore after the eina_log stuff, as ecore_init might call > those loging functions. So the order of the shutdown should be fixed too whoops > > Vincent > > > + > > _e_dbus_log_dom = eina_log_domain_register("e_dbus", > > E_DBUS_COLOR_DEFAULT); if (_e_dbus_log_dom < 0) > > { > > - EINA_LOG_ERR("Enable to create a 'e_dbus' log domain"); > > + EINA_LOG_ERR("Enable to create an 'e_dbus' log domain"); > > eina_shutdown(); > > + ecore_shutdown(); > > return --_edbus_init_count; > > } > > > > @@ -634,6 +642,7 @@ > > e_dbus_object_shutdown(); > > eina_log_domain_unregister(_e_dbus_log_dom); > > _e_dbus_log_dom = -1; > > + ecore_shutdown(); > > eina_shutdown(); > > > > return _edbus_init_count; > > > > -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
