Hi Mathieu, I've just had a quick look at your patch.
Looks quite good, though I have a two points: - please declare vars at the beginning of the function - Normalize to 0.0->1.0 instead of 0->100 as it might easen direct mapping to sliders, etc.? This also adresses "level > 100" vs. "level > 100.0" - Is partial dimming expected or should already commited dimming be undone? e.g. 1 of 2 drivers supports dimming. What do you guys think/expect? Else it looks good to me, though my driver just doesn't support it. So I just can't test it. BR, Leif 2011/2/7 Mike Blumenkrantz <[email protected]>: > On Mon, 31 Jan 2011 19:14:25 +0100 (CET) > [email protected] wrote: > >> Hello, >> >> Since the merge window is open, I would like to submit this patch for ecore. >> To make it short, it is a modified version of the patch I send two weeks ago. >> It implement backlight control through xrand extension. >> >> Mathieu > Looks pretty good I think, gonna wait for Leif or raster to double check > though. > > -- > Mike Blumenkrantz > Zentific: NULL pointer dereferences now 50% off! > > ------------------------------------------------------------------------------ > The modern datacenter depends on network connectivity to access resources > and provide services. The best practices for maximizing a physical server's > connectivity to a physical network are well understood - see how these > rules translate into the virtual world? > http://p.sf.net/sfu/oracle-sfdevnlfb > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
