Dear Tom
Thanks for fast reply.
> You are referring to the animation that happens when you resize? (but
> position is still correct, right?)
Yes, the the position is correct.
But the bouncing occur when you resize it. It is not correct. Right?
> Oh, ok, yeah I can see there's an issue, and your'e saying putting this
> return back fixes stuff?
There are two solution.
The first is to return back the part "if ((nx == px) && (ny == py)) return;".
The second is to remove "elm_smart_scroller_child_region_set"
in "_smart_scrollto_x", "_smart_scrollto_y" like below patch.
What is right?
Thanks,
Jaehwan Kim.
Index: src/lib/els_scroller.c
===================================================================
--- src/lib/els_scroller.c (revision 57004)
+++ src/lib/els_scroller.c (work copy)
@@ -441,7 +441,7 @@ _smart_scrollto_x(Smart_Data *sd, double t_in, Eva
elm_smart_scroller_child_pos_get(sd->smart_obj, &x, &y);
elm_smart_scroller_child_viewport_size_get(sd->smart_obj, &w, &h);
x = pos_x;
- elm_smart_scroller_child_region_set(sd->smart_obj, x, y, w, h);
+ //elm_smart_scroller_child_region_set(sd->smart_obj, x, y, w, h);
return;
}
t = ecore_loop_time_get();
@@ -452,7 +452,7 @@ _smart_scrollto_x(Smart_Data *sd, double t_in, Eva
sd->scrollto.x.t_end = t + t_in;
elm_smart_scroller_child_pos_get(sd->smart_obj, &x, &y);
elm_smart_scroller_child_viewport_size_get(sd->smart_obj, &w, &h);
- elm_smart_scroller_child_region_set(sd->smart_obj, x, y, w, h);
+ //elm_smart_scroller_child_region_set(sd->smart_obj, x, y, w, h);
if (!sd->scrollto.x.animator)
{
if (!sd->scrollto.y.animator)
@@ -508,7 +508,7 @@ _smart_scrollto_y(Smart_Data *sd, double t_in, Eva
elm_smart_scroller_child_pos_get(sd->smart_obj, &x, &y);
elm_smart_scroller_child_viewport_size_get(sd->smart_obj, &w, &h);
y = pos_y;
- elm_smart_scroller_child_region_set(sd->smart_obj, x, y, w, h);
+ //elm_smart_scroller_child_region_set(sd->smart_obj, x, y, w, h);
return;
}
t = ecore_loop_time_get();
@@ -519,7 +519,7 @@ _smart_scrollto_y(Smart_Data *sd, double t_in, Eva
sd->scrollto.y.t_end = t + t_in;
elm_smart_scroller_child_pos_get(sd->smart_obj, &x, &y);
elm_smart_scroller_child_viewport_size_get(sd->smart_obj, &w, &h);
- elm_smart_scroller_child_region_set(sd->smart_obj, x, y, w, h);
+ //elm_smart_scroller_child_region_set(sd->smart_obj, x, y, w, h);
if (!sd->scrollto.y.animator)
{
if (!sd->scrollto.x.animator)
-----Original Message-----
From: Tom Hacohen [mailto:[email protected]]
Sent: Monday, February 14, 2011 5:31 PM
To: Jaehwan Kim
Cc: [email protected]
Subject: RE: [E-devel] E SVN: tasn trunk/TMP/st/elementary/src/lib
Dear Jaehwan,
Thanks for your email, my comments are inlined:
On Mon, 2011-02-14 at 16:38 +0900, Jaehwan Kim wrote:
> You can test it simply.
> Execute "elementary_test" and go into "Scroller".
> Resize larger to observe in detail.
> Drag down until white background be shown enough and mouse up.
> It'll go back 0,0 by the bouncing.
> Then resize the window a little.
> The scroller will be jumped in a moment.
> Please check this issue.
You are referring to the animation that happens when you resize? (but
position is still correct, right?)
>
> I have another issue.
> Currently, elm_scroller_region_bring_in do not work well.
> You can test it simply, too.
> Execute "elementary_test" and go into "Scroller".
> Push any button.
> It just work in vertical.
> The reason for it is the removing the part
> "if ((nx == px) && (ny == py)) return;" in
> "elm_smart_scroller_retion_show_internal".
> To work "bring_in" well, we have to add " if ((nx == px) && (ny == py))
> return" again
> Or fix like following patch.
Oh, ok, yeah I can see there's an issue, and your'e saying putting this
return back fixes stuff?
Thanks,
Tom.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
