On 02/16/2011 09:28 PM, Mathieu Taillefumier wrote: >>> Sorry I am late :-(. I thought I send the last version version earlier >>> but I might have made a mistake. The last version of the patch includes >>> the following modifications >>> >>> - fix some typo and some comments. >>> - the intensity is now set to be between (0,1) following Leif advise >>> - I suppressed the global variable _backlight and declared it inside all >>> three functions. It avoids a problem if the backlight atomic changes >>> value. >> >> - Why having static _backlight when you always assign it a new value? >> - _backlight is sometimes int, sometimes Atom > No reasons, I made a mistake when I add the line that's all. > >> - double _backlight == None check in >> ecore_x_randr_screen_backlight_level_set > No reason either. Enclosed to this email the patch that contains the > corrections.
In ecore_x_randr_screen_backlight_level_set, why no return on _backlight == None? S. ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
