On Sat, 19 Feb 2011, Enlightenment SVN wrote:
> Log: > Only print if verbose and TODO++ why using fprintf(stder ***) and not eina_log ? Vincent > > Author: englebass > Date: 2011-02-19 12:54:03 -0800 (Sat, 19 Feb 2011) > New Revision: 57175 > Trac: http://trac.enlightenment.org/e/changeset/57175 > > Modified: > trunk/efreet/src/bin/efreet_icon_cache_create.c > > Modified: trunk/efreet/src/bin/efreet_icon_cache_create.c > =================================================================== > --- trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-19 20:53:16 UTC > (rev 57174) > +++ trunk/efreet/src/bin/efreet_icon_cache_create.c 2011-02-19 20:54:03 UTC > (rev 57175) > @@ -26,6 +26,8 @@ > * - Need to cache all exts searched and extra_dirs, so we know if we > * need to rescan dirs. Then re-enable cache_directory_find(). > * - Need to check if files has disappeared, as we only add new. > + * - Base dir is touched on icon theme update, no need to scan all. > + * - There is something weird going on with inheritance when adding > extensions > */ > > static Eina_Array *exts = NULL; > @@ -303,8 +305,9 @@ > Efreet_Icon_Theme *inherit; > > inherit = eina_hash_find(icon_themes, name); > - if (!inherit) fprintf(stderr, "Theme `%s` not found for `%s`.\n", > - name, theme->name.internal); > + if (!inherit && verbose) > + fprintf(stderr, "Theme `%s` not found for `%s`.\n", > + name, theme->name.internal); > if (!cache_scan(inherit, themes, icons, dirs, changed)) return > EINA_FALSE; > } > } > @@ -333,8 +336,9 @@ > Efreet_Cache_Icon_Theme *inherit; > > inherit = eina_hash_find(icon_themes, name); > - if (!inherit) fprintf(stderr, "Theme `%s` not found for `%s`.\n", > - name, theme->theme.name.internal); > + if (!inherit && verbose) > + fprintf(stderr, "Theme `%s` not found for `%s`.\n", > + name, theme->theme.name.internal); > if (check_changed(inherit)) return EINA_TRUE; > } > } > @@ -858,10 +862,11 @@ > > if (cache_scan(&(theme->theme), themes, icons, theme->dirs, &changed)) > { > - fprintf(stderr, "generated: '%s' %i (%i)\n", > - theme->theme.name.internal, > - changed, > - eina_hash_population(icons)); > + if (verbose) > + fprintf(stderr, "generated: '%s' %i (%i)\n", > + theme->theme.name.internal, > + changed, > + eina_hash_population(icons)); > if (changed) > { > Eina_Iterator *icons_it; > @@ -879,7 +884,7 @@ > > if (theme->changed || changed) > { > - if (theme->changed) > + if (theme->changed && verbose) > fprintf(stderr, "theme change: %s %lld\n", > theme->theme.name.internal, theme->last_cache_check); > eet_data_write(theme_ef, theme_edd, theme->theme.name.internal, > theme, 1); > } > @@ -944,7 +949,8 @@ > /* Save fallback in the right part */ > if (cache_fallback_scan(icons, theme->dirs, &changed)) > { > - fprintf(stderr, "generated: fallback %i (%i)\n", changed, > eina_hash_population(icons)); > + if (verbose) > + fprintf(stderr, "generated: fallback %i (%i)\n", changed, > eina_hash_population(icons)); > if (changed) > { > Eina_Iterator *icons_it; > > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
