On Mon, Feb 28, 2011 at 11:02 AM, Cedric BAIL <[email protected]> wrote: > 2011/2/28 Guillaume Friloux <[email protected]>: >> Hello id like to speak a bit about ecore_file_monitor_inotify >> >> Until SVN rev56210 >> (http://trac.enlightenment.org/e/changeset?new=56210%40trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c&old=54996%40trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c >> <http://trac.enlightenment.org/e/changeset?new=56210%40trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c&old=54996%40trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c>) >> it wasnt able to see file modifications until the file is closed (so >> everything like logfiles couldnt be watched), it got fixed, but this broke >> the ability to see when a file is completely written. >> >> So what i have been thinking is to add something like >> ECORE_FILE_EVENT_CLOSED that would be raised on a IN_CLOSE_WRITE inotify >> event, while IN_ATTRIB and IN_MODIFY would still raise >> ECORE_FILE_EVENT_MODIFY. >> >> So there will be both features from before and after rev56210, and i hope >> this would get everyone happy. > > I have been thinking about this for quite some time, and I can't make > my opinion. It breaks ABI a little, but not that much, because current > broken application will stay broken, and the working one should > continue to work. So I am quite ok to let it in for 1.0.x and 1.x > branch as usefull fix, but not so sure. If someone else could review > it to, would be helpful.
Seems like I am the only one with an opinion on that, so it's in svn. Thanks -- Cedric BAIL ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
