On Tue, 1 Mar 2011, Cedric BAIL wrote:

On Tue, Mar 1, 2011 at 11:24 AM, Vincent Torri <[email protected]> wrote:
On Tue, 1 Mar 2011, Cedric BAIL wrote:
On Tue, Mar 1, 2011 at 11:06 AM, Vincent Torri <[email protected]>
wrote:

add @since i nthe doc of the enum.

How ? Or where ?

you added in Ecore_File.h the enum ECORE_FILE_EVENT_CLOSED, which is an API
addition

Yes, I know that :-) But how do I add the @since in the enum ?

http://trac.enlightenment.org/e/browser/trunk/ecore/src/lib/ecore_file/Ecore_File.h#L63

line 64 : the doc of the enum begins here. So you can add the comment there

Vincent


On Tue, 1 Mar 2011, Enlightenment SVN wrote:

Log:
ecore: fix detection of complete file write in ecore_file inotify.

 Patch by Guillaume Friloux <[email protected]>.


Author:       cedric
Date:         2011-03-01 01:57:13 -0800 (Tue, 01 Mar 2011)
New Revision: 57450
Trac:         http://trac.enlightenment.org/e/changeset/57450

Modified:
 trunk/ecore/ChangeLog trunk/ecore/src/lib/ecore_file/Ecore_File.h
trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c

Modified: trunk/ecore/ChangeLog
===================================================================
--- trunk/ecore/ChangeLog     2011-03-01 09:53:58 UTC (rev 57449)
+++ trunk/ecore/ChangeLog     2011-03-01 09:57:13 UTC (rev 57450)
@@ -76,3 +76,8 @@
2011-03-01 Raoul Hecky

      * Add ecore_con_url_ssl_verify_peer_set API.
+
+2011-03-01 Guillaume Friloux
+
+     * Fix detection of complete file write in ecore_file inotify.
+

Modified: trunk/ecore/src/lib/ecore_file/Ecore_File.h
===================================================================
--- trunk/ecore/src/lib/ecore_file/Ecore_File.h       2011-03-01
09:53:58 UTC (rev 57449)
+++ trunk/ecore/src/lib/ecore_file/Ecore_File.h       2011-03-01
09:57:13 UTC (rev 57450)
@@ -73,7 +73,8 @@
   ECORE_FILE_EVENT_DELETED_FILE,      /**< Deleted file event. */
   ECORE_FILE_EVENT_DELETED_DIRECTORY, /**< Deleted directory event. */
   ECORE_FILE_EVENT_DELETED_SELF,      /**< Deleted monitored directory
event. */
-   ECORE_FILE_EVENT_MODIFIED           /**< Modified file or directory
event. */
+   ECORE_FILE_EVENT_MODIFIED,          /**< Modified file or directory
event. */
+   ECORE_FILE_EVENT_CLOSED             /**< Closed file event */
} Ecore_File_Event;

/**

Modified: trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c
===================================================================
--- trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c
2011-03-01 09:53:58 UTC (rev 57449)
+++ trunk/ecore/src/lib/ecore_file/ecore_file_monitor_inotify.c
2011-03-01 09:57:13 UTC (rev 57450)
@@ -218,7 +218,7 @@
   if (mask & IN_CLOSE_WRITE)
     {
        if (!isdir)
-          em->func(em->data, em, ECORE_FILE_EVENT_MODIFIED, buf);
+          em->func(em->data, em, ECORE_FILE_EVENT_CLOSED, buf);
     }
   if (mask & IN_MODIFY)
     {



------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data
in
Real-Time with Splunk. Collect, index and harness all the fast moving IT
data
generated by your applications, servers and devices whether physical,
virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
enlightenment-svn mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn




------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT
data
generated by your applications, servers and devices whether physical,
virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel





--
Cedric BAIL





--
Cedric BAIL

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to