Hey Mike,

nice you fixed the segv. Maybe you could also set the corresponding
part in  e's config back to software. It's pointless that the config
says it uses openGL while it doesn't cause it fails to get a context.

BR,

Leif

2011/3/8 Enlightenment SVN <no-re...@enlightenment.org>:
> Log:
> _evas_gl_common_viewport_set segv fix: ROUND 2!
>
>
> Author:       discomfitor
> Date:         2011-03-07 17:00:21 -0800 (Mon, 07 Mar 2011)
> New Revision: 57561
> Trac:         http://trac.enlightenment.org/e/changeset/57561
>
> Modified:
>  trunk/evas/ChangeLog 
> trunk/evas/src/modules/engines/gl_common/evas_gl_context.c
>
> Modified: trunk/evas/ChangeLog
> ===================================================================
> --- trunk/evas/ChangeLog        2011-03-07 22:31:11 UTC (rev 57560)
> +++ trunk/evas/ChangeLog        2011-03-08 01:00:21 UTC (rev 57561)
> @@ -135,3 +135,7 @@
>  2011-02-27  Vincent Torri
>
>        * Fixed static linking of the bmp, wbmp and tga loaders
> +
> +2011-03-07  Mike Blumenkrantz
> +
> +        * Fix segv when trying to set gl viewpoint with NULL ctx
>
> Modified: trunk/evas/src/modules/engines/gl_common/evas_gl_context.c
> ===================================================================
> --- trunk/evas/src/modules/engines/gl_common/evas_gl_context.c  2011-03-07 
> 22:31:11 UTC (rev 57560)
> +++ trunk/evas/src/modules/engines/gl_common/evas_gl_context.c  2011-03-08 
> 01:00:21 UTC (rev 57561)
> @@ -292,6 +292,7 @@
>    GLfloat proj[16];
>    int w = 1, h = 1, m = 1, rot = 1, foc = 0;
>
> +   EINA_SAFETY_ON_NULL_RETURN(gc);
>    foc = gc->foc;
>    // surface in pipe 0 will be the same as all pipes
>    if ((gc->pipe[0].shader.surface == gc->def_surface) ||
>
>
> ------------------------------------------------------------------------------
> What You Don't Know About Data Connectivity CAN Hurt You
> This paper provides an overview of data connectivity, details
> its effect on application quality, and explores various alternative
> solutions. http://p.sf.net/sfu/progress-d2d
> _______________________________________________
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>

------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to