On Sat, 19 Mar 2011 22:09:41 +0100 (CET) Vincent Torri <vto...@univ-evry.fr> wrote:
> > > On Sat, 19 Mar 2011, Enlightenment SVN wrote: > > > Log: > > fix crash in e-notify-send by verifying that init occurs as expected > > > > > > Author: discomfitor > > Date: 2011-03-19 13:46:44 -0700 (Sat, 19 Mar 2011) > > New Revision: 57903 > > Trac: http://trac.enlightenment.org/e/changeset/57903 > > > > Modified: > > trunk/e_dbus/ChangeLog trunk/e_dbus/src/bin/notify-send.c > > > > Modified: trunk/e_dbus/ChangeLog > > =================================================================== > > --- trunk/e_dbus/ChangeLog 2011-03-19 20:29:24 UTC (rev 57902) > > +++ trunk/e_dbus/ChangeLog 2011-03-19 20:46:44 UTC (rev 57903) > > @@ -6,3 +6,6 @@ > > > > * Fix build with DSO. > > > > +2011-03-19 Mike Blumenkrantz > > + > > + * Fix crash in e-notify-send when invalid DBUS_SESSION_BUS_ADDRESS > > is specified > > > > Modified: trunk/e_dbus/src/bin/notify-send.c > > =================================================================== > > --- trunk/e_dbus/src/bin/notify-send.c 2011-03-19 20:29:24 UTC (rev > > 57902) +++ trunk/e_dbus/src/bin/notify-send.c 2011-03-19 20:46:44 > > UTC (rev 57903) @@ -11,6 +11,16 @@ > > #include <Ecore.h> > > #include <E_Notify.h> > > > > +#define S(X) #X > > + > > +#define CHECK(X) do { \ > > + if (!X) \ > > + { \ > > + fprintf(stderr, "%s:%i: Error calling %s!\n", __FILE__, __LINE__, > > S(X)); \ > > + exit(1); \ > > + } \ > > +} while (0) > > any reason to not use eina_log ? > > Vincent > > > + > > void > > version(void) > > { > > @@ -80,9 +90,9 @@ > > int print_id = 0; > > E_Notification *n; > > > > - eina_init(); > > - ecore_init(); > > - e_notification_init(); > > + CHECK(eina_init()); > > + CHECK(ecore_init()); > > + CHECK(e_notification_init()); > > n = e_notification_new(); > > e_notification_app_name_set(n, "e-notify-send"); > > e_notification_timeout_set(n, -1); > > > > laziness mostly -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
