As the subject really. _edje_fetch is a get call, so no point doing it to
assign to a variable that is about to go out of scope.
I can commit if someone prefers.
Regards,
nash
>From 961906e692dfd8dcd051e9a0668fc19309cf6adc Mon Sep 17 00:00:00 2001
From: Brett Nash <n...@nash.id.au>
Date: Tue, 22 Mar 2011 13:46:39 +0900
Subject: [PATCH] Edje: remove pointless call to _edje_fetch
Also tag edje_fetch as pure... since it's pretty clean.
---
src/lib/edje_private.h | 2 +-
src/lib/edje_smart.c | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/lib/edje_private.h b/src/lib/edje_private.h
index 0b044e6..755a3c0 100644
--- a/src/lib/edje_private.h
+++ b/src/lib/edje_private.h
@@ -1538,7 +1538,7 @@ void _edje_text_class_member_del(Edje *ed, const char *text_class);
void _edje_text_class_members_free(void);
void _edje_text_class_hash_free(void);
-Edje *_edje_fetch(const Evas_Object *obj);
+Edje *_edje_fetch(const Evas_Object *obj) EINA_PURE;
int _edje_freeze(Edje *ed);
int _edje_thaw(Edje *ed);
int _edje_block(Edje *ed);
diff --git a/src/lib/edje_smart.c b/src/lib/edje_smart.c
index 358e6b6..72cbf8d 100644
--- a/src/lib/edje_smart.c
+++ b/src/lib/edje_smart.c
@@ -39,7 +39,6 @@ edje_object_add(Evas *evas)
}
e = evas_object_smart_add(evas, _edje_smart);
- ed = _edje_fetch(e);
return e;
}
--
1.7.4.1
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
