On Sun, 27 Mar 2011 20:42:20 +0200 Mathieu Taillefumier <[email protected]> said:
get back to us with patches when you're done :) > On 03/27/2011 08:12 PM, Leif Middelschulte wrote: > > 2011/3/27 Mathieu Taillefumier<[email protected]>: > >> On 03/27/2011 07:40 PM, Leif Middelschulte wrote: > >>> > >>> Hi, > >>> > >>> thanks for your fast reply. > >>> > >>> Hm.. but you'll have to _set_ it on a monitor basis/per monitor, right? > >>> So all this function would return is "One connected monitor does > >>> support backlight control". If you want to actually do _anything_ with > >>> the backlight you'll have to iterate over every connected monitor > >>> anyway, won't you? > >> > >> Yes, you are right but (there is always a but :-)) in this case I am not > >> interested by the specific output so I just check the atomic value. > > Okay, I guess you're doing it this way because of the things below. > >> Moreover there are two functions in ecore that allow the backlight to be > >> set. One in general and the other one per output. I just use the first one > >> in e17. > > That first function is just a convinience function. It will (as it > > doesn't do it yet) iterate internally over every connected and enabled > > output. > The backlight functions are implemented actually. I wrote the code and > it was add to svn few months back :-). > > > > For the scope of e17 I'd suggest you use ecore's per output function > > and complete e's internal randr information structure (see > > e/src/bin/e_randr.c) and use that in your dialog to configure the > > outputs. > Yes I think this is the right way to do it. Just add the properties for > each screen and then loop over the list of all screens that support > backlight is better since we can control each screen individually. > > Mathieu > > > > BR, > > > > Leif > > > > P.S.: Would you mind to join #edevelop for a sec? > >> > >> cheers > >> > >> Mathieu > >> > >> > >>> > >>> BR, > >>> > >>> Leif > >>> > >>> 2011/3/27 Mathieu Taillefumier<[email protected]>: > >>>> > >>>> Hey, > >>>>> > >>>>> We have two possible ways to go here: Either return a special value as > >>>>> e.g. -1.0 in the (already available) backlight get-function or > >>>>> introduce a new call as you suggested. > >>>>> While the second option is fine for me as well, I wonder about the > >>>>> naming. I haven't read of any default naming scheme within EFL for > >>>>> this kind of functions, so I just searched the documentation for it. > >>>>> We might want to follow naming of other functions returning support > >>>>> values as e.g.: > >>>>> > >>>>> ecore_con_ssl_available_get > >>>>> ecore_ipc_ssl_available_get > >>>>> > >>>>> So please adjust the name accordingly or - if you find other more > >>>>> appropriate functionnaming - use another naming. > >>>> > >>>> I changed the name of the function. I could also use the get function but > >>>> in > >>>> this case I had to check all outputs while I just want to know if there > >>>> is > >>>> an output supporting it (I do not care about the output in this case) > >>>> that's > >>>> why I was proposing to add this function. > >>>> > >>>> Mathieu > >>>> > >>>>> Leif > >>>>> > >>>>> P.S.: What's you IRC nick, so I can talk to you about the dialog? > >>>> > >>>> I am not often on irc. but when I am there i often use matphy. > >>>>> > >>>>> 2011/3/26 Mathieu Taillefumier<[email protected]>: > >>>>>> > >>>>>> On 03/26/2011 11:24 PM, Mike Blumenkrantz wrote: > >>>>>>> > >>>>>>> On Sat, 26 Mar 2011 23:17:03 +0100 > >>>>>>> Mathieu Taillefumier<[email protected]> wrote: > >>>>>>> > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> I assume the API for the 1.1.0 version of Ecore is not frozen yet and > >>>>>>>> I > >>>>>>>> would like to propose this patch that had a small function to Ecore > >>>>>>>> randr extension. The function just check if the backlight property is > >>>>>>>> supported or not. Any comments are welcome. > >>>>>>>> > >>>>>>>> I would appreciate that this function is included in the lib because > >>>>>>>> it > >>>>>>>> would make my life easier to integrate backlight support in e17. The > >>>>>>>> basic implementation is finished and working fine but I still need to > >>>>>>>> write the module for setting the backlight properties (normal and > >>>>>>>> reduced intensity, the method used to set the backlight and the > >>>>>>>> timeout). > >>>>>>>> > >>>>>>>> best > >>>>>>>> > >>>>>>>> Mathieu > >>>>>>> > >>>>>>> Your doxygen needs work. > >>>>>>> > >>>>>> indeed. I corrected my patch. > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> ------------------------------------------------------------------------------ > >>>>>> Enable your software for Intel(R) Active Management Technology to meet > >>>>>> the > >>>>>> growing manageability and security demands of your customers. > >>>>>> Businesses > >>>>>> are taking advantage of Intel(R) vPro (TM) technology - will your > >>>>>> software > >>>>>> be a part of the solution? Download the Intel(R) Manageability Checker > >>>>>> today! http://p.sf.net/sfu/intel-dev2devmar > >>>>>> _______________________________________________ > >>>>>> enlightenment-devel mailing list > >>>>>> [email protected] > >>>>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >>>>>> > >>>>>> > >>>> > >>>> > >> > >> > > > ------------------------------------------------------------------------------ > Enable your software for Intel(R) Active Management Technology to meet the > growing manageability and security demands of your customers. Businesses > are taking advantage of Intel(R) vPro (TM) technology - will your software > be a part of the solution? Download the Intel(R) Manageability Checker > today! http://p.sf.net/sfu/intel-dev2devmar > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Create and publish websites with WebMatrix Use the most popular FREE web apps or write code yourself; WebMatrix provides all the features you need to develop and publish your website. http://p.sf.net/sfu/ms-webmatrix-sf _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
